Skip to content

NA omitting #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajmcdon opened this issue May 24, 2022 · 2 comments
Closed

NA omitting #27

dajmcdon opened this issue May 24, 2022 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@dajmcdon
Copy link
Contributor

Default na_omit processing should likely remove NAs from y and x at training time, but only x at prediction time. Using default {recipes} steps, one would do something like:

# Baseline AR3
r <- epi_recipe(x) %>% 
  step_epi_ahead(death_rate, ahead = 7) %>%
  step_epi_lag(death_rate, lag = c(0, 7, 14)) %>%
  step_epi_lag(case_rate, lag = c(0, 7, 14)) %>%
  step_naomit(all_predictors()) %>%
  # below, `skip` means we don't do this at predict time
  # we should probably do something useful here to avoid user error
  step_naomit(all_outcomes(), skip = TRUE)

Write a wrapper that adds combines these steps into 1.

@dajmcdon dajmcdon added the good first issue Good for newcomers label May 24, 2022
@kenmawer
Copy link
Contributor

kenmawer commented Jun 3, 2022

I will get started on and finish this tomorrow.

kenmawer added a commit that referenced this issue Jun 7, 2022
@kenmawer
Copy link
Contributor

kenmawer commented Jul 5, 2022

Completed with PR #79.

@kenmawer kenmawer closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants