Skip to content

step_epi_naomit branched off frosting. #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Conversation

kenmawer
Copy link
Contributor

This is taken from a messy pull request, as if it were broken up.

@kenmawer kenmawer requested a review from dajmcdon as a code owner June 28, 2022 22:42
Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the Rd files for create_layer and new_epi_recipe_blueprint are here. (They shouldn't be). Maybe rerun devtools::document()?

#' step_epi_naomit()

step_epi_naomit <- function(recipe) {
stopifnot("recipe" %in% class(recipe))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better is

stopifnot(inherits(x, "recipe")

Copy link
Contributor Author

@kenmawer kenmawer Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rerun devtools::document and the Rd files for create_layer and new_epi_recipe_blueprint haven't been deleted. For the former, it claims that it comes from create-layer.R.
Also, I updated the second comment.

@dajmcdon dajmcdon merged commit 0b0ceb7 into frosting Jul 1, 2022
@dajmcdon dajmcdon deleted the km-step_epi_naomit-good branch July 1, 2022 15:44
@kenmawer kenmawer mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants