Skip to content

More class creation #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajmcdon opened this issue May 24, 2022 · 0 comments
Closed

More class creation #29

dajmcdon opened this issue May 24, 2022 · 0 comments
Labels
question Further information is requested

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented May 24, 2022

I already wrote an epi_recipe wrapper around recipe. This performs 2 functions specific to our use case. First, the template is always a single row to avoid copies. Second, it handles time_value and geo_value (and other keys) properly.

  1. Do we implement a epi_workflow around workflow. Current workflow does not support post processing of any type. And it doesn't have many useful S3 methods (residuals, fitted, etc).
  2. Do we implement wrappers around predict to keep the keys.
  3. epi_recipe doesn't currently add a class (it has class recipe). Do we add one?

We need to do something to solve 2.

@dajmcdon dajmcdon added the question Further information is requested label May 24, 2022
kenmawer added a commit that referenced this issue Jun 7, 2022
@dajmcdon dajmcdon closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant