Add support to delete model within Predictor and Pipeline class. #647

chuyang-deng · 2019-02-16T00:08:26Z

Issue #, if available:
#447

Description of changes:
Closing #638 in favor of this PR.

Continuation of #630

Add support to delete model within Predictor and Pipeline class.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ChoiByungWook

This looks really good!

Just a few small comments.

src/sagemaker/predictor.py

ChoiByungWook

Let's get a review from @icywang86rui

README.rst

icywang86rui · 2019-02-19T00:50:43Z

src/sagemaker/predictor.py

+
+        """
+        for model_name in self._model_names:
+            self.sagemaker_session.delete_model(model_name)


what's the desired behavior if one or some of the requests fail?

Good catch! I think we should catch the exception and tell user the deletion is incomplete if one or model delete_model() fail.

tests/unit/test_chainer.py

icywang86rui · 2019-02-20T21:30:43Z

src/sagemaker/predictor.py

+            for model_name in self._model_names:
+                self.sagemaker_session.delete_model(model_name)
+        except Exception:
+            raise Exception('One or more models cannot be deleted, the deletion is incomplete.')


say if we have 3 models and the second one failed do we want to try to delete the third one?

icywang86rui · 2019-02-21T19:02:13Z

src/sagemaker/predictor.py

+                request_failed = True
+
+        if request_failed:
+            raise Exception('One or more models cannot be deleted, please retry.')


let's print the failed model names here as well

icywang86rui

Ship!

* Add list_feature_groups API (#647) * feat: Feature/get record api (#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (#664) * feat: Add DatasetBuilder class (#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (#699) * feat: Add pandas.Dataframe as base case (#708) * feat: Add with_feature_group method in DatasetBuilder (#726) * feat: Handle merge and timestamp filters (#727) * feat: Add to_dataframe method in DatasetBuilder (#729) * Address TODOs (#731) * Unit test for DatasetBuilder (#734) * fix: Fix list_feature_groups max_results (#744) * Add integration tests for create_dataset (#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>

* Add list_feature_groups API (aws#647) * feat: Feature/get record api (aws#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (aws#664) * feat: Add DatasetBuilder class (aws#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (aws#699) * feat: Add pandas.Dataframe as base case (aws#708) * feat: Add with_feature_group method in DatasetBuilder (aws#726) * feat: Handle merge and timestamp filters (aws#727) * feat: Add to_dataframe method in DatasetBuilder (aws#729) * Address TODOs (aws#731) * Unit test for DatasetBuilder (aws#734) * fix: Fix list_feature_groups max_results (aws#744) * Add integration tests for create_dataset (aws#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (aws#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>

* Add list_feature_groups API (#647) * feat: Feature/get record api (#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (#664) * feat: Add DatasetBuilder class (#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (#699) * feat: Add pandas.Dataframe as base case (#708) * feat: Add with_feature_group method in DatasetBuilder (#726) * feat: Handle merge and timestamp filters (#727) * feat: Add to_dataframe method in DatasetBuilder (#729) * Address TODOs (#731) * Unit test for DatasetBuilder (#734) * fix: Fix list_feature_groups max_results (#744) * Add integration tests for create_dataset (#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>

* Add list_feature_groups API (aws#647) * feat: Feature/get record api (aws#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (aws#664) * feat: Add DatasetBuilder class (aws#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (aws#699) * feat: Add pandas.Dataframe as base case (aws#708) * feat: Add with_feature_group method in DatasetBuilder (aws#726) * feat: Handle merge and timestamp filters (aws#727) * feat: Add to_dataframe method in DatasetBuilder (aws#729) * Address TODOs (aws#731) * Unit test for DatasetBuilder (aws#734) * fix: Fix list_feature_groups max_results (aws#744) * Add integration tests for create_dataset (aws#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (aws#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>

Chuyang Deng added 6 commits February 15, 2019 15:52

Support for Predictor to delete SageMaker model.

6e09223

Fix unit test.

f381475

Add delete_model to Predictor and Pipeline.

55193a2

initialize endpoint config and model names within predictor

eae499c

Add a missed README example change.

c055924

update docs and test for predictor

d3c614f

ChoiByungWook mentioned this pull request Feb 16, 2019

Model linkage #638

Closed

4 tasks

ChoiByungWook self-requested a review February 16, 2019 00:37

ChoiByungWook suggested changes Feb 16, 2019

View reviewed changes

src/sagemaker/predictor.py Show resolved Hide resolved

src/sagemaker/predictor.py Show resolved Hide resolved

Init endpoint_config_name in Predictor's constructor.

edd00a6

ChoiByungWook reviewed Feb 18, 2019

View reviewed changes

src/sagemaker/predictor.py Outdated Show resolved Hide resolved

ChoiByungWook requested a review from icywang86rui February 18, 2019 19:28

Modify method name (_get_model_names).

c89b8f5

ChoiByungWook previously approved these changes Feb 18, 2019

View reviewed changes

ChoiByungWook self-assigned this Feb 19, 2019

icywang86rui reviewed Feb 19, 2019

View reviewed changes

Update README docstring and predictor delete model error handling.

c552c04

chuyang-deng dismissed ChoiByungWook’s stale review via c552c04 February 19, 2019 19:05

icywang86rui reviewed Feb 20, 2019

View reviewed changes

Continue deleting models with failed delete requests.

c6f6d82

icywang86rui reviewed Feb 21, 2019

View reviewed changes

ChoiByungWook and others added 3 commits February 21, 2019 13:10

add sphinx-build in tox (#653)

204b197

add twine check in tox (#651)

be7e86c

Print failed model delete names in error message.

af76289

icywang86rui approved these changes Feb 21, 2019

View reviewed changes

ChoiByungWook approved these changes Feb 21, 2019

View reviewed changes

ChoiByungWook added 2 commits February 21, 2019 13:38

Merge branch 'master' into predictor_delete

f6f46fd

Merge branch 'master' into predictor_delete

e959e54

ChoiByungWook merged commit 5740939 into aws:master Feb 22, 2019

mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022

Add list_feature_groups API (aws#647)

743e8c3

mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022

Add list_feature_groups API (aws#647)

ad9e259

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to delete model within Predictor and Pipeline class. #647

Add support to delete model within Predictor and Pipeline class. #647

chuyang-deng commented Feb 16, 2019

ChoiByungWook left a comment

ChoiByungWook left a comment

icywang86rui Feb 19, 2019

chuyang-deng Feb 19, 2019

icywang86rui Feb 20, 2019

icywang86rui Feb 21, 2019

icywang86rui left a comment

Add support to delete model within Predictor and Pipeline class. #647

Add support to delete model within Predictor and Pipeline class. #647

Conversation

chuyang-deng commented Feb 16, 2019

Merge Checklist

ChoiByungWook left a comment

Choose a reason for hiding this comment

ChoiByungWook left a comment

Choose a reason for hiding this comment

icywang86rui Feb 19, 2019

Choose a reason for hiding this comment

chuyang-deng Feb 19, 2019

Choose a reason for hiding this comment

icywang86rui Feb 20, 2019

Choose a reason for hiding this comment

icywang86rui Feb 21, 2019

Choose a reason for hiding this comment

icywang86rui left a comment

Choose a reason for hiding this comment