pass accelerator_type for tfs model #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesterhazy
reviewed
Feb 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #667 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 71 71
Lines 5489 5489
=======================================
Hits 5090 5090
Misses 399 399
Continue to review full report at Codecov.
|
jesterhazy
approved these changes
Feb 26, 2019
mizanfiu
pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Eric Zou <[email protected]>
mizanfiu
pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Eric Zou <[email protected]>
claytonparnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Add list_feature_groups API (#647) * feat: Feature/get record api (#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (#664) * feat: Add DatasetBuilder class (#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (#699) * feat: Add pandas.Dataframe as base case (#708) * feat: Add with_feature_group method in DatasetBuilder (#726) * feat: Handle merge and timestamp filters (#727) * feat: Add to_dataframe method in DatasetBuilder (#729) * Address TODOs (#731) * Unit test for DatasetBuilder (#734) * fix: Fix list_feature_groups max_results (#744) * Add integration tests for create_dataset (#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>
claytonparnell
pushed a commit
to claytonparnell/sagemaker-python-sdk
that referenced
this pull request
Dec 16, 2022
* Add list_feature_groups API (aws#647) * feat: Feature/get record api (aws#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (aws#664) * feat: Add DatasetBuilder class (aws#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (aws#699) * feat: Add pandas.Dataframe as base case (aws#708) * feat: Add with_feature_group method in DatasetBuilder (aws#726) * feat: Handle merge and timestamp filters (aws#727) * feat: Add to_dataframe method in DatasetBuilder (aws#729) * Address TODOs (aws#731) * Unit test for DatasetBuilder (aws#734) * fix: Fix list_feature_groups max_results (aws#744) * Add integration tests for create_dataset (aws#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (aws#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>
mufaddal-rohawala
pushed a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 19, 2022
* Add list_feature_groups API (aws#647) * feat: Feature/get record api (aws#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (aws#664) * feat: Add DatasetBuilder class (aws#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (aws#699) * feat: Add pandas.Dataframe as base case (aws#708) * feat: Add with_feature_group method in DatasetBuilder (aws#726) * feat: Handle merge and timestamp filters (aws#727) * feat: Add to_dataframe method in DatasetBuilder (aws#729) * Address TODOs (aws#731) * Unit test for DatasetBuilder (aws#734) * fix: Fix list_feature_groups max_results (aws#744) * Add integration tests for create_dataset (aws#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (aws#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>
mufaddal-rohawala
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Add list_feature_groups API (#647) * feat: Feature/get record api (#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (#664) * feat: Add DatasetBuilder class (#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (#699) * feat: Add pandas.Dataframe as base case (#708) * feat: Add with_feature_group method in DatasetBuilder (#726) * feat: Handle merge and timestamp filters (#727) * feat: Add to_dataframe method in DatasetBuilder (#729) * Address TODOs (#731) * Unit test for DatasetBuilder (#734) * fix: Fix list_feature_groups max_results (#744) * Add integration tests for create_dataset (#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>
JoseJuan98
pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
* Add list_feature_groups API (aws#647) * feat: Feature/get record api (aws#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (aws#664) * feat: Add DatasetBuilder class (aws#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (aws#699) * feat: Add pandas.Dataframe as base case (aws#708) * feat: Add with_feature_group method in DatasetBuilder (aws#726) * feat: Handle merge and timestamp filters (aws#727) * feat: Add to_dataframe method in DatasetBuilder (aws#729) * Address TODOs (aws#731) * Unit test for DatasetBuilder (aws#734) * fix: Fix list_feature_groups max_results (aws#744) * Add integration tests for create_dataset (aws#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (aws#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>
JoseJuan98
pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
* Add list_feature_groups API (aws#647) * feat: Feature/get record api (aws#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (aws#664) * feat: Add DatasetBuilder class (aws#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (aws#699) * feat: Add pandas.Dataframe as base case (aws#708) * feat: Add with_feature_group method in DatasetBuilder (aws#726) * feat: Handle merge and timestamp filters (aws#727) * feat: Add to_dataframe method in DatasetBuilder (aws#729) * Address TODOs (aws#731) * Unit test for DatasetBuilder (aws#734) * fix: Fix list_feature_groups max_results (aws#744) * Add integration tests for create_dataset (aws#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (aws#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>
nmadan
pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
* Add list_feature_groups API (aws#647) * feat: Feature/get record api (aws#650) Co-authored-by: Eric Zou <[email protected]> * Add delete_record API (aws#664) * feat: Add DatasetBuilder class (aws#667) Co-authored-by: Eric Zou <[email protected]> * feat: Add to_csv method in DatasetBuilder (aws#699) * feat: Add pandas.Dataframe as base case (aws#708) * feat: Add with_feature_group method in DatasetBuilder (aws#726) * feat: Handle merge and timestamp filters (aws#727) * feat: Add to_dataframe method in DatasetBuilder (aws#729) * Address TODOs (aws#731) * Unit test for DatasetBuilder (aws#734) * fix: Fix list_feature_groups max_results (aws#744) * Add integration tests for create_dataset (aws#743) * feature: Aggregate commits * fix: as_of, event_range, join, default behavior and duplicates… (aws#764) * Bug fixed - as_of, event_range, join, default behavior and duplicates and tests Bugs: 1. as_of was not working properly on deleted events 2. Same event_time_range 3. Join was not working when including feature names 4. Default sql was returning only most recent, whereas it should all excluding duplicates 5. Include duplicates was not return all non-deleted data 6. instanceof(dataframe) case was also applied to non-df cases while join 7. Include column was returning unnecessary columns. * Fix on pylint error * Fix on include_duplicated_records for panda data frames * Fix format issue for black * Bug fixed related to line break * Bug fix related to dataframe and inclde_deleted_record and include_duplicated_record * Addressed comments and code refactored * changed to_csv to to_csv_file and added error messages for query limit and recent record limit * Revert a change which was not intended * Resolved the leak of feature group deletion in integration test * Added doc update for dataset builder * Fix the issue in doc Co-authored-by: Yiming Zou <[email protected]> Co-authored-by: Brandon Chatham <[email protected]> Co-authored-by: Eric Zou <[email protected]> Co-authored-by: jiapinw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/amazon-sagemaker-examples#613 (comment)
4732545#r32336726
Description of changes:
Pass in accelerator_type into the deploy() for the REST API TFS Model object, which should result in an exception, as EI for the TFS container isn't supported.
I can also change it so that the failure happens on SageMaker side instead of client side as the image doesn't exist and is currently in the works, however this is to mitigate users from pulling down CPU or GPU only images when expecting EI images.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.