-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add new APIs to clean up resources from predictor and transformer. #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… transformer to delete model.
I only included changes regarding deleting endpoint/endpoint config in this PR. model class linkage changes will be sent in a separate one because many files will be changed to link model and I don't want this PR to be too long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Let's update the first PR conversation in regards to why the linking of the model isn't done within the Transformer class and instead the session is called.
Let's also relate this PR and your upcoming model linkage PR to this issue: #447
As it is in regards to delete_model and delete_endpoint config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some general comments. It looks really good!
Let's fix the title of this PR, since the original title was too long and it is being cut off.
…on and transformer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just left some minor comments in regards to the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
… transformer to delete model.
…on and transformer.
@@ -8,6 +8,9 @@ CHANGELOG | |||
* doc-fix: update information about saving models in the MXNet README | |||
* doc-fix: change ReadTheDocs links from latest to stable | |||
* doc-fix: add ``transform_fn`` information and fix ``input_fn`` signature in the MXNet README | |||
* feature: Support for ``Predictor`` to delete endpoint configuration by default when calling ``delete_endpoint()`` | |||
* feature: Support for ``model`` to delete SageMaker model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the model should be uppercase, but we can fix in the other PR.
… transformer to delete model.
Issue #, if available:
#447
Description of changes:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.