Skip to content

Add support to delete model within Predictor and Pipeline class. #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 22, 2019
Merged

Add support to delete model within Predictor and Pipeline class. #647

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6e09223
Support for Predictor to delete SageMaker model.
Feb 13, 2019
f381475
Fix unit test.
Feb 13, 2019
55193a2
Add delete_model to Predictor and Pipeline.
Feb 15, 2019
eae499c
initialize endpoint config and model names within predictor
Feb 15, 2019
c055924
Add a missed README example change.
Feb 15, 2019
d3c614f
update docs and test for predictor
Feb 15, 2019
edd00a6
Init endpoint_config_name in Predictor's constructor.
Feb 18, 2019
c89b8f5
Modify method name (_get_model_names).
Feb 18, 2019
c552c04
Update README docstring and predictor delete model error handling.
Feb 19, 2019
c6f6d82
Continue deleting models with failed delete requests.
Feb 21, 2019
204b197
add sphinx-build in tox (#653)
ChoiByungWook Feb 21, 2019
be7e86c
add twine check in tox (#651)
ChoiByungWook Feb 21, 2019
af76289
Print failed model delete names in error message.
Feb 21, 2019
f6f46fd
Merge branch 'master' into predictor_delete
ChoiByungWook Feb 21, 2019
e959e54
Merge branch 'master' into predictor_delete
ChoiByungWook Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/sagemaker/predictor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,15 @@ def delete_model(self):
"""Deletes the Amazon SageMaker models backing this predictor.

"""
try:
for model_name in self._model_names:
request_failed = False
for model_name in self._model_names:
try:
self.sagemaker_session.delete_model(model_name)
except Exception:
raise Exception('One or more models cannot be deleted, the deletion is incomplete.')
except Exception: # pylint: disable=broad-except
request_failed = True

if request_failed:
raise Exception('One or more models cannot be deleted, please retry.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's print the failed model names here as well


def _get_endpoint_config_name(self):
endpoint_desc = self.sagemaker_session.sagemaker_client.describe_endpoint(EndpointName=self.endpoint)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_predictor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ def test_delete_model():
def test_delete_model_fail():
sagemaker_session = empty_sagemaker_session()
sagemaker_session.sagemaker_client.delete_model = Mock(side_effect='Could not find model.')
expected_error_message = 'One or more models cannot be deleted, the deletion is incomplete.'
expected_error_message = 'One or more models cannot be deleted, please retry.'

predictor = RealTimePredictor(ENDPOINT, sagemaker_session=sagemaker_session)

Expand Down