Integrate ArduinoCloudThing with ArduinoIoTCloud #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct typos
decode() needs to be rewritten
Fixed memory leak in CborArray, fixed ssize_t, #define CBOR_INT_T int
Accepts a pointer to the actual value
TOTALLY UNTESTED
The volume setter function was incorrectly named setSwitch.
…obal timestamp. (#55) This is necessary because right now we are relying on the RTC within the SAMD MCU which is instantiated (RTCZero) within the ArduinoIoTCloud library and reference within ArduinoCloudThing via extern devlaration. Due to the extern binding this is a very brittle dependency which can be easily destroyed, it is therefore better to explicitly register a function which provides the time (this can be serviced by the TimeService class available in ArduinoIoTCloud
…poch type timestamp In arduino-libraries/ArduinoCloudThing#55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in #93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
…Thing into integrate-ArduinoCloudThing
…raries when running CI via GitHub actions
…hat ArduinoCloudThing is no longer a stand-alone library but integrated with ArduinoIoTCloud
aentinger
force-pushed
the
integrate-ArduinoCloudThing
branch
from
ff14dd2 to
86a6544
Compare
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 98.05% 97.01% -1.05%
==========================================
Files 4 28 +24
Lines 103 972 +869
==========================================
+ Hits 101 943 +842
- Misses 2 29 +27
Continue to review full report at Codecov.
|
…l as the cbor library
aentinger
force-pushed
the
integrate-ArduinoCloudThing
branch
from
86a6544 to
caed2b6
Compare
|
Memory usage change @caed2b636a752cd6d9f988380f38a9e7a478392a
|
…e namespace 'cbor'
…psulating its methods into namespace OTA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #125.