Skip to content

Register a epoch timestamp retrieval function with ArduinoCloudThing #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

aentinger
Copy link
Contributor

This allows class ArduinoCloudThing to obtain a 'epoch' timestamp which is used during synchronisation and which has been implemented so far via an 'extern' dependency to RTCZero. Since this kind of hidden dependency (basically a global object across 2 separate Arduino libraries) is very brittle the depdency is made clear by explicitly registering a function to provide the required timestamp.

This allows class ArduinoCloudThing to obtain a 'epoch' timestamp which is used during synchronisation and which has been implemented so far via an 'extern' dependency to RTCZero. Since this kind of hidden dependency (basically a global object across 2 separate Arduino libraries) is very brittle the depdency is made clear by explicitly registering a function to provide the required timestamp.
@aentinger
Copy link
Contributor Author

Successfully tested on PROD with

  • MKR GSM 1400 ✔️
  • MKR WiFi 1010 ✔️
  • ESP 8266 ✔️

@aentinger aentinger marked this pull request as ready for review February 27, 2020 05:25
@aentinger aentinger requested a review from AlbyIanna February 27, 2020 05:25
@aentinger aentinger changed the title Register a callback function with ArduinoCloudThing Register a epoch timestamp retrieval function with ArduinoCloudThing Feb 27, 2020
aentinger added a commit to arduino-libraries/ArduinoCloudThing that referenced this pull request Feb 27, 2020
…poch type timestamp

In #55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in arduino-libraries/ArduinoIoTCloud#93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
aentinger added a commit to arduino-libraries/ArduinoCloudThing that referenced this pull request Feb 27, 2020
…poch type timestamp

In #55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in arduino-libraries/ArduinoIoTCloud#93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
@aentinger aentinger merged commit edbca65 into master Mar 2, 2020
@aentinger aentinger deleted the ArduinoCloudThing-register-getTimeCallback branch March 2, 2020 06:07
aentinger added a commit to arduino-libraries/ArduinoCloudThing that referenced this pull request Mar 9, 2020
…poch type timestamp

In #55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in arduino-libraries/ArduinoIoTCloud#93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
aentinger added a commit that referenced this pull request Jun 3, 2020
…poch type timestamp

In arduino-libraries/ArduinoCloudThing#55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in #93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant