This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Removal of hidden dependency to RTCZero which is used to retrieve a epoch type timestamp #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
…poch type timestamp In #55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in arduino-libraries/ArduinoIoTCloud#93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
aentinger
force-pushed
the
cleanup-remove-extern-RTCZero-dependency
branch
from
6083e59 to
bcd9374
Compare
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 95.41% 95.39% -0.02%
==========================================
Files 24 24
Lines 872 869 -3
==========================================
- Hits 832 829 -3
Misses 40 40
Continue to review full report at Codecov.
|
|
Successfully tested on PROD with
|
AlbyIanna
approved these changes
Mar 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in arduino-libraries/ArduinoIoTCloud#93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether.