This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Adding a function to register a callback function for retrieving a global timestamp #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
aentinger
force-pushed
the
retrieve-timestamp-via-callback-method
branch
from
990c261 to
6433958
Compare
This comment has been minimized.
This comment has been minimized.
aentinger
force-pushed
the
retrieve-timestamp-via-callback-method
branch
from
6433958 to
fc6c29f
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 95.73% 95.41% -0.32%
==========================================
Files 24 24
Lines 867 872 +5
==========================================
+ Hits 830 832 +2
- Misses 37 40 +3
Continue to review full report at Codecov.
|
…obal timestamp. This is necessary because right now we are relying on the RTC within the SAMD MCU which is instantiated (RTCZero) within the ArduinoIoTCloud library and reference within ArduinoCloudThing via extern devlaration. Due to the extern binding this is a very brittle dependency which can be easily destroyed, it is therefore better to explicitly register a function which provides the time (this can be serviced by the TimeService class available in ArduinoIoTCloud
aentinger
force-pushed
the
retrieve-timestamp-via-callback-method
branch
from
fc6c29f to
85078a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 95.73% 95.41% -0.32%
==========================================
Files 24 24
Lines 867 872 +5
==========================================
+ Hits 830 832 +2
- Misses 37 40 +3 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 95.73% 95.41% -0.32%
==========================================
Files 24 24
Lines 867 872 +5
==========================================
+ Hits 830 832 +2
- Misses 37 40 +3
Continue to review full report at Codecov.
|
AlbyIanna
approved these changes
Feb 25, 2020
aentinger
added a commit
that referenced
this pull request
Feb 27, 2020
…poch type timestamp In #55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in arduino-libraries/ArduinoIoTCloud#93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
aentinger
added a commit
that referenced
this pull request
Feb 27, 2020
…poch type timestamp In #55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in arduino-libraries/ArduinoIoTCloud#93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
aentinger
added a commit
that referenced
this pull request
Mar 9, 2020
…poch type timestamp In #55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in arduino-libraries/ArduinoIoTCloud#93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
aentinger
added a commit
to arduino-libraries/ArduinoIoTCloud
that referenced
this pull request
Jun 3, 2020
…poch type timestamp In arduino-libraries/ArduinoCloudThing#55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in #93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because right now we are relying on the RTC within the SAMD MCU which is instantiated (RTCZero) within the ArduinoIoTCloud library and reference within ArduinoCloudThing via extern devlaration. Due to the extern binding this is a very brittle dependency which can be easily destroyed, it is therefore better to explicitly register a function which provides the time (this can be serviced by the TimeService class available in ArduinoIoTCloud.
Successfully tested on PROD with