Integrate ArduinoCloudThing #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really dislike that I had to expose the Thing object but otherwise the addProperty() call would become terrible. I added a line on Cloud_blink example to show the composition of functions on properties. It can be safely removed in the next iteration.
|
Umm, i think this was merged too early ... |
Merged
aentinger
pushed a commit
that referenced
this pull request
Jun 3, 2020
Fixed memory leak in CborArray, fixed ssize_t, #define CBOR_INT_T int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really dislike that I had to expose the Thing object but otherwise the addProperty() call (which is a terrible macro trick) would become terrible.
@sandeepmistry if you have a better idea it's always welcome 😄
I added a line on Cloud_blink example to show the composition of functions on properties. It can be safely removed in the next iteration.