Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

i18n - Extended Number Format Symbol Rules #9013

Closed
wants to merge 2 commits into from
Closed

i18n - Extended Number Format Symbol Rules #9013

wants to merge 2 commits into from

Conversation

mgallag
Copy link
Contributor

@mgallag mgallag commented Sep 10, 2014

  • Added numberformatsymbolsext.js to Closure Slurper script
  • Regenerated locales

This should correct the configurations for many locales.

Fixes currency symbol issue in #8931.

@mgallag mgallag mentioned this pull request Sep 10, 2014
Closed
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Narretz
Copy link
Contributor

Narretz commented Sep 10, 2014

Hi, it looks like you have merged the angular/master branch into your branch? You need to delete these commits, and rebase your branch against current master if you want to stay up to date

@lgalfaso
Copy link
Contributor

Thanks for the PR. This looks like a duplicate of #4858

@mgallag mgallag force-pushed the i18n-config branch 2 times, most recently from bc2c27a to c2c515b Compare September 10, 2014 18:49
@mgallag
Copy link
Contributor Author

mgallag commented Sep 10, 2014

@Narretz Sorry, I was trying to squash this change into 2 commits per a comment in #8931 and may have messed it up. Sorry, first time doing this.

@mary-poppins I filled out a CLA yesterday but I'll resubmit.

@caitp
Copy link
Contributor

caitp commented Sep 10, 2014

Try this: git rebase -i HEAD~16 --- remove all of the commits (following the first commit authored by you, f62232f) that aren't yours, and then git pull --rebase origin master, and then force push to your branch on github.

@mgallag
Copy link
Contributor Author

mgallag commented Sep 10, 2014

@caitp That did the trick! Thanks! :)

@caitp
Copy link
Contributor

caitp commented Sep 10, 2014

awesome --- it generally looks good to me, will verify in a few hours and merge it

@btford
Copy link
Contributor

btford commented Sep 10, 2014

LGTM; just waiting on @mary-poppins to confirm your CLA (she periodically does an automatic check). If you haven't already, can you make sure that the email address you author commits with is the same one you've signed the CLA with?

@btford btford mentioned this pull request Sep 10, 2014
Closed
@caitp caitp added this to the 1.3.0-rc.2 milestone Sep 10, 2014
@caitp caitp self-assigned this Sep 10, 2014
@mgallag
chore(ngLocale): Include numberformatsymbolext.js in Closure Slurper …
38b59b1 
…Script

Adds missing number format and symbol rules to Closure slurper script.

Closes angular#6179
@mgallag
fix(ngLocale): Regenerate Locale Files
9e5ba41 
Fixes number formatting and symbols for many locales.
Adds support for additional locales.

Closes angular#8931
Closes angular#8583
Closes angular#7799
@mgallag
Copy link
Contributor Author

mgallag commented Sep 10, 2014

@btford You were right, it looks like the commits had the wrong email address on them. They should be corrected now.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@caitp
Copy link
Contributor

caitp commented Sep 11, 2014

Thanks @mgallag --- @lgalfaso had another i18n commit checked in earlier, so I had to regenerate the locales again. Thanks for the fix, good stuff

@caitp caitp closed this in 871f321 Sep 11, 2014
@btford
Copy link
Contributor

btford commented Sep 11, 2014

👏

@lgalfaso
Copy link
Contributor

👍

@Narretz Narretz mentioned this pull request Sep 11, 2014
Closed
@mgallag mgallag deleted the i18n-config branch September 11, 2014 18:56
@mgallag mgallag restored the i18n-config branch September 11, 2014 18:56
@mgallag mgallag deleted the i18n-config branch September 11, 2014 18:56
caitp pushed a commit that referenced this pull request Sep 16, 2014
@mgallag @caitp
chore(ngLocale): Include numberformatsymbolext.js in Closure Slurper …
b979ee1 
…Script

Adds missing number format and symbol rules to Closure slurper script.

Closes #6179
Closes #9013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@caitp caitp

Labels
cla: yes frequency: moderate type: bug
Projects
None yet
Milestone
1.3.0-rc.2
Development

Successfully merging this pull request may close these issues.
6 participants
@mgallag @mary-poppins @Narretz @lgalfaso @caitp @btford