Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

i18n: Taking numberformatsymbolsext into account #4858

Closed
wants to merge 1 commit into from

Conversation

iamedu
Copy link

@iamedu iamedu commented Nov 9, 2013

There are some errors in certain locale files, I noticed most latin american currencies were wrong. The problem is that closure library keeps a separate file numberformatsymbolsext.js for some languages.

This change uses this file too to generate the correct currency chars.

The locale generation process now downloads number format symbols from
this url too

http://closure-library.googlecode.com/svn/trunk/closure/goog/i18n/numberformatsymbolsext.js

Most locales should now be correct

The locale generation process now downloads number format symbols from
this url too

http://closure-library.googlecode.com/svn/trunk/closure/goog/i18n/numberformatsymbolsext.js

Most locales should now be correct
@petebacondarwin
Copy link
Contributor

LGTM

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@iamedu
Copy link
Author

iamedu commented Dec 7, 2013

Sorry, I have just signed the CLA right now!

@lisgiu
Copy link

lisgiu commented Apr 2, 2014

We've got a similar problem for our application for Switzerland. The location-files for the French and Italian part aren't correct or are missing. This commit would solve our problem.
Will this proposed change be merged into the angular:master? Thanks.

@Narretz
Copy link
Contributor

Narretz commented Sep 11, 2014

I guess this was handled by #9013 Better lat than never, right?

@Narretz Narretz closed this Sep 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants