This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(i18n): fix typo at i18n generation code #8962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo at i18n generation code. This would remove the property `macFrac` that has no meaning from all the generated locales
|
If needed, I can repost this PR with the i18n regenerated, but I think it would pollute the PR a lot |
|
On this one? This probably should have been merged last week, it looks good |
|
I'm gonna merge it then. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo at i18n generation code. This would remove the property
macFracthat has no meaning from all the generated localesTo complete the patch, there is a need to generate the i18n locales once again, but adding this to this PR would make it really hard to spot the single change