ngLocale es-AR

[BartoGabriel]

I am Argentine. Our currency is not the Euro (https://github.com/angular/angular.js/blob/master/src/ngLocale/angular-locale_es-ar.js#L66)
Our currency symbol is "$". The symbol is placed before the number.

Example:
$ 14.212,82

[jeffbcross]

Thanks for pointing it out, want to submit a PR?

[caitp]

We still get these from Closure Library, https://github.com/google/closure-library/blob/master/closure/goog/i18n/numberformatsymbolsext.js#L3938 (they are getting them from CLDR)

But, since we don't update the locales each release, a PR wouldn't hurt

[lgalfaso]

It looks like what is needed is also to include the extended number formats, this is

diff --git a/i18n/update-closure.sh b/i18n/update-closure.sh
index 4a9290d..576926c 100755
--- a/i18n/update-closure.sh
+++ b/i18n/update-closure.sh
@@ -14,4 +14,5 @@ curl "$I18N_BASE/currency.js" > closure/currencySymbols.js
 curl "$I18N_BASE/datetimesymbols.js" > closure/datetimeSymbols.js
 curl "$I18N_BASE/datetimesymbolsext.js" > closure/datetimeSymbolsExt.js
 curl "$I18N_BASE/numberformatsymbols.js" > closure/numberSymbols.js
+curl "$I18N_BASE/numberformatsymbolsext.js" >> closure/numberSymbols.js
 curl "$I18N_BASE/pluralrules.js" > closure/pluralRules.js

then update and generate the locales. I am not 100% happy with the change as this will also add ~100 new locales, but it is still better than having the wrong information in the locales we already ship

@caitp @jeffbcross WDYT?

[caitp]

there's wrong information in closure's numberSymbolsExt actually, so I'm not sure how that would really help. They don't supply the currency symbol for a lot of those latin countries, which is why we're getting issues about "argentina does not use the euro!" and stuff (because it just inherits from the default 'ES' locale).

Honestly we really just need to ditch closure and go with cldr directly, but I haven't been working on that for a few weeks, work is stale

[BartoGabriel]

I do not think this completely resolved.

As I showed in the example, the correct way to display a value is:
$ 14.212,82
But now shown:
14.212,82 $

The error is in line 87,88,89,90:
https://github.com/angular/angular.js/blob/master/src/ngLocale/angular-locale_es-ar.js#L87

The correct way would be:

"negPre": "\u00a4-",
"negSuf": "",
"posPre": "\u00a4",
"posSuf": ""

[lgalfaso]

@BartoGabriel it looks like that will be a lot harder. The issue is that the CLDR has two formats for currency for es-AR. These are
"accounting": "#,##0.00 ¤"
"standard": "¤#,##0.00"

For better or worst, the Closure Library is picking accounting (the other one is not even present). Then angular takes this from the Closure Library and generates the locales

[BartoGabriel]

You are right, the error is drawn from CLDR.

I do not understand because reason is so in CLDR... We do not use the format that way.
But you have reason. The error should not be reported here, should be reported in CLDR, since the accounting format is wrong.

[srl295]

@BartoGabriel @caitp hi, CLDR person here. CLDR 26 has just finished final beta, please check latest CLDR data as well and provide feedback. Picking "accounting" by default sounds wrong off the top of my head. http://unicode.org/pipermail/unicode/2014-September/000935.html

[BartoGabriel]

@srl295 hi, I already reported this in CLDR. But I received no response...
http://unicode.org/cldr/trac/ticket/7898

I also think the "standard" format must be used. But, I do not know that this decision will take.

[srl295]

@BartoGabriel Thanks for reporting it. CLDR meets weekly and so expect an update in about 24 hours. Is there a ticket raised against Closure?

[BartoGabriel]

I did not report this to Closure.
Can be seen the pattern wrong:
https://github.com/google/closure-library/blob/master/closure/goog/i18n/numberformatsymbolsext.js#L3950

But these files are generated automatically. First should be arranged from the main source.
It seems important to know because "accounting format" is used by default.

[srl295]

@BartoGabriel @caitp see an update on the CLDR bug above. As to Closure, please file a bug with them, it turns out I have no contact with Closure.