-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
Currency symbol is '$'. The symbol is placed before the number. Closes angular#8583
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
I'm sorry, I just signed the CLA. |
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
this does not look like the right patch as these files are auto-generated |
@lgalfaso is right. But what's confusing is that it looks like the currency is correct in Closure Library, and has been since the inception of the repository: https://github.com/google/closure-library/blob/86920016968c1ee9c9f3ba202be8b22b5c641c8c/closure/goog/i18n/currency.js#L220 But for some reason our script is not using that value. |
Closing this PR since this should be fixed upstream. Leaving the original issue open though. |
@jeffbcross I am not sure this is an issue at the Closure Library, Argentina's currency symbol is at numberformatsymbolsext.js and not at numberformatsymbols.js, we only import the first one. Now, we do import datetimeSymbols.js and datetimeSymbolsExt.js, so we end up generating the 'es_AR' locale as we have the date, but not with the correct currency symbol. As pointed out at #8583 (comment) it would be best to go strait to the CLDR and generate the locales from there, but I think it would take a lot of time with very little benefit |
Currency symbol is '$'. The symbol is placed before the number.
Closes #8583