Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fixes Argentina's currency. #8606

Closed
wants to merge 1 commit into from
Closed

Conversation

BartoGabriel
Copy link

Currency symbol is '$'. The symbol is placed before the number.

Closes #8583

Currency symbol is '$'. The symbol is placed before the number.

Closes angular#8583
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@BartoGabriel
Copy link
Author

I'm sorry, I just signed the CLA.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@lgalfaso
Copy link
Contributor

this does not look like the right patch as these files are auto-generated

@jeffbcross
Copy link
Contributor

@lgalfaso is right. But what's confusing is that it looks like the currency is correct in Closure Library, and has been since the inception of the repository: https://github.com/google/closure-library/blob/86920016968c1ee9c9f3ba202be8b22b5c641c8c/closure/goog/i18n/currency.js#L220

But for some reason our script is not using that value.

@jeffbcross
Copy link
Contributor

Closing this PR since this should be fixed upstream. Leaving the original issue open though.

@jeffbcross jeffbcross closed this Sep 3, 2014
@lgalfaso
Copy link
Contributor

lgalfaso commented Sep 3, 2014

@jeffbcross I am not sure this is an issue at the Closure Library, Argentina's currency symbol is at numberformatsymbolsext.js and not at numberformatsymbols.js, we only import the first one. Now, we do import datetimeSymbols.js and datetimeSymbolsExt.js, so we end up generating the 'es_AR' locale as we have the date, but not with the correct currency symbol.

As pointed out at #8583 (comment) it would be best to go strait to the CLDR and generate the locales from there, but I think it would take a lot of time with very little benefit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngLocale es-AR
4 participants