-
Notifications
You must be signed in to change notification settings - Fork 12k
build(@angular/cli): update sourcemap-istanbul-instrumenter-loader #4560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hansl
merged 3 commits into
angular:master
from
filipesilva:update-instanbul-instrumenter-license
Feb 9, 2017
Merged
build(@angular/cli): update sourcemap-istanbul-instrumenter-loader #4560
hansl
merged 3 commits into
angular:master
from
filipesilva:update-instanbul-instrumenter-license
Feb 9, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf0352e
to
549d589
Compare
Thanks to @deepsweet for the license update! Followup from webpack-contrib/istanbul-instrumenter-loader#39 Partially address angular#3884
549d589
to
47c257f
Compare
hansl
approved these changes
Feb 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work!
filipesilva
added a commit
that referenced
this pull request
Feb 10, 2017
#4560 notes were not included.
filipesilva
added a commit
that referenced
this pull request
Feb 10, 2017
#4560 notes were not included.
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
…ngular#4560) Thanks to @deepsweet for the license update! Followup from webpack-contrib/istanbul-instrumenter-loader#39 Partially address angular#3884
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
) angular#4560 notes were not included.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @deepsweet for the license update!
Followup from webpack-contrib/istanbul-instrumenter-loader#39
Partially address #3884
BREAKING CHANGE:
The default LCOV file is now
coverage/lcov.info
instead ofcoverage/coverage.lcov
.ng test --code-coverage
now useskarma-coverage-istanbul-reporter
instead ofkarma-remap-istanbul
.To update follow these steps in your project:
npm uninstall karma-remap-istanbul
npm install karma-coverage-istanbul-reporter
Then copy
karma.conf.js
from a new project, or update it manually:require('karma-remap-istanbul'),
withrequire('karma-coverage-istanbul-reporter'),
['progress', 'karma-remap-istanbul']
with['progress', 'coverage-istanbul']
with