Skip to content

refactor: sort dependencies alphabetically #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

refactor: sort dependencies alphabetically #5090

wants to merge 3 commits into from

Conversation

BernhardRode
Copy link

Sorted dependencies makes merging a lot easier.
Helps a lot, when upgrading the cli and pulling in the correct deps.

Sorted dependencies makes merging a lot easier. 
Helps a lot, when upgrading the cli and pulling in the correct deps.
"@angular/platform-browser-dynamic": "<%= ng4 ? '>=4.0.0-beta <5.0.0' : '^2.4.0' %>",
"@angular/platform-browser": "<%= ng4 ? '>=4.0.0-beta <5.0.0' : '^2.4.0' %>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install will flip the order of these two. @angular/platform-browser should be first.

"karma-coverage-istanbul-reporter": "^0.2.0",
"karma-jasmine-html-reporter": "^0.2.2",
"karma-jasmine": "~1.1.0",
"karma": "~1.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install will flip the order of these aswell. Shortest name first.

@BernhardRode
Copy link
Author

I just use yarn and a sort alphabetical Plugin inside of my editor.
I'll double check that tomorrow.

@grizzm0
Copy link
Contributor

grizzm0 commented Mar 1, 2017

You should have rebased, not merge master.

And the only package I can see that is not in alphabetic order is "karma-coverage-istanbul-reporter" (comes from #4560) and it's still not in the correct place.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants