Skip to content

docs: update changelog with code coverage breaking changes #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2017

Conversation

filipesilva
Copy link
Contributor

#4560 notes were not included.

Copy link
Contributor

@Brocco Brocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the update details belong in the changelog. Can you put the instructions in the related issue and link to it instead?

@filipesilva
Copy link
Contributor Author

@Brocco afaik they do, and should be copied automatically from the commit according to the contributing doc. It's also how I've seen these changes be presented in angular/angular.

@hansl
Copy link
Contributor

hansl commented Feb 12, 2017

The commit is based on the commit message, not the PR message. Seems like your PR was containing the text.

LGTM.

@hansl hansl merged commit b1790e6 into master Feb 12, 2017
@filipesilva filipesilva deleted the filipesilva-patch-1 branch February 13, 2017 12:32
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants