Skip to content

Commit 47c257f

Browse files
committed
build(@angular/cli): update sourcemap-istanbul-instrumenter-loader
Thanks to @deepsweet for the license update! Followup from webpack-contrib/istanbul-instrumenter-loader#39 Partially address #3884
1 parent 4e06612 commit 47c257f

File tree

5 files changed

+10
-13
lines changed

5 files changed

+10
-13
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
"inflection": "^1.7.0",
6666
"inquirer": "^3.0.0",
6767
"isbinaryfile": "^3.0.0",
68+
"istanbul-instrumenter-loader": "^2.0.0",
6869
"json-loader": "^0.5.4",
6970
"karma-sourcemap-loader": "^0.3.7",
7071
"karma-webpack": "^2.0.0",
@@ -91,7 +92,6 @@
9192
"silent-error": "^1.0.0",
9293
"source-map": "^0.5.6",
9394
"source-map-loader": "^0.1.5",
94-
"sourcemap-istanbul-instrumenter-loader": "^0.2.0",
9595
"style-loader": "^0.13.1",
9696
"stylus": "^0.54.5",
9797
"stylus-loader": "^2.4.0",

packages/@angular/cli/blueprints/ng2/files/karma.conf.js

+5-7
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module.exports = function (config) {
88
plugins: [
99
require('karma-jasmine'),
1010
require('karma-chrome-launcher'),
11-
require('karma-remap-istanbul'),
11+
require('karma-coverage-istanbul-reporter'),
1212
require('@angular/cli/plugins/karma')
1313
],
1414
files: [
@@ -20,18 +20,16 @@ module.exports = function (config) {
2020
mime: {
2121
'text/x-typescript': ['ts','tsx']
2222
},
23-
remapIstanbulReporter: {
24-
reports: {
25-
html: 'coverage',
26-
lcovonly: './coverage/coverage.lcov'
27-
}
23+
coverageIstanbulReporter: {
24+
reports: [ 'html', 'lcovonly' ],
25+
fixWebpackSourcePaths: true
2826
},
2927
angularCli: {
3028
config: './angular-cli.json',
3129
environment: 'dev'
3230
},
3331
reporters: config.angularCli && config.angularCli.codeCoverage
34-
? ['progress', 'karma-remap-istanbul']
32+
? ['progress', 'coverage-istanbul']
3533
: ['progress'],
3634
port: 9876,
3735
colors: true,

packages/@angular/cli/blueprints/ng2/files/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"karma-chrome-launcher": "^2.0.0",
3838
"karma-cli": "^1.0.1",
3939
"karma-jasmine": "^1.0.2",
40-
"karma-remap-istanbul": "^0.6.0",
40+
"karma-coverage-istanbul-reporter": "^0.2.0",
4141
"protractor": "~5.1.0",
4242
"ts-node": "1.2.1",
4343
"tslint": "^4.3.0",

packages/@angular/cli/models/webpack-configs/test.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const ProgressPlugin = require('webpack/lib/ProgressPlugin');
1818
* know they are used.
1919
*
2020
* require('source-map-loader')
21-
* require('sourcemap-istanbul-instrumenter-loader')
21+
* require('istanbul-instrumenter-loader')
2222
*
2323
*/
2424

@@ -31,13 +31,12 @@ const getTestConfig = function (projectRoot, environment, appConfig, testConfig)
3131

3232
if (testConfig.codeCoverage) {
3333
extraRules.push({
34-
test: /\.(js|ts)$/, loader: 'sourcemap-istanbul-instrumenter-loader',
34+
test: /\.(js|ts)$/, loader: 'istanbul-instrumenter-loader',
3535
enforce: 'post',
3636
exclude: [
3737
/\.(e2e|spec)\.ts$/,
3838
/node_modules/
3939
],
40-
query: { 'force-sourcemap': true }
4140
});
4241
}
4342

packages/@angular/cli/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"semver": "^5.1.0",
7373
"silent-error": "^1.0.0",
7474
"source-map-loader": "^0.1.5",
75-
"sourcemap-istanbul-instrumenter-loader": "^0.2.0",
75+
"istanbul-instrumenter-loader": "^2.0.0",
7676
"style-loader": "^0.13.1",
7777
"stylus": "^0.54.5",
7878
"stylus-loader": "^2.4.0",

0 commit comments

Comments
 (0)