Merge maths/fibonacci.py and maths/fibonacci_sequence_recursion.py #5738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor determinant method to create separate minor and cofactor methods. Add respective unit tests for new methods. Rename methods using snake case to follow Python naming conventions.
Co-authored-by: John Law <[email protected]>
Co-authored-by: John Law <[email protected]>
ghost
added
awaiting reviews
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Merged the contents of
fibonacci_sequence_recursion.pyintomaths/fibonacci.py.Fixes #5735
^ I'm marking it as "fixed" but in actuality there are still other Fibonacci files that may need to be merged as well.
maths/fibonacci.pyandfibonacci_sequence_recursion.pywere simply the ones that most clearly needed merging and the ones that would be the easiest to merge.Checklist:
Fixes: #{$ISSUE_NO}.