Rewrite maths/fibonacci.py #5734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor determinant method to create separate minor and cofactor methods. Add respective unit tests for new methods. Rename methods using snake case to follow Python naming conventions.
Co-authored-by: John Law <[email protected]>
Co-authored-by: John Law <[email protected]>
ghost
added
awaiting reviews
|
I think its outdated now? |
@l3str4nge yeah I made this PR before the other one (#5738) in which I merged the two Fibonacci files. There were still some minor differences between this PR and that one though, so I resolved the merge conflict and it should be OK to go now. |
l3str4nge
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #5733 by rewriting
maths/fibonacci.py, the otherfibonacci.pyfileChecklist:
Fixes: #{$ISSUE_NO}.