Skip to content

Commit 84cca21

Browse files
tianyizheng02poyea
andauthored
Rewrite maths/fibonacci.py (#5734)
* Rewrite parts of Vector and Matrix methods * Refactor determinant method and add unit tests Refactor determinant method to create separate minor and cofactor methods. Add respective unit tests for new methods. Rename methods using snake case to follow Python naming conventions. * Reorganize Vector and Matrix methods * Update linear_algebra/README.md Co-authored-by: John Law <[email protected]> * Fix punctuation and wording * Apply suggestions from code review Co-authored-by: John Law <[email protected]> * Deduplicate euclidean length method for Vector * Add more unit tests for Euclidean length method * Fix bug in unit test for euclidean_length * Remove old comments for magnitude method * Rewrite maths/fibonacci.py * Rewrite timer and add unit tests * Fix typos in fib_binet unit tests * Fix typos in fib_binet unit tests * Clean main method Co-authored-by: John Law <[email protected]>
1 parent 68ca61e commit 84cca21

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: maths/fibonacci.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ def fib_binet(n: int) -> list[int]:
9595
NOTE 1: this function diverges from fib_iterative at around n = 71, likely
9696
due to compounding floating-point arithmetic errors
9797
98-
NOTE 2: this function overflows on n >= 1475 because of the size limitations
99-
of Python floats
98+
NOTE 2: this function doesn't accept n >= 1475 because it overflows
99+
thereafter due to the size limitations of Python floats
100100
>>> fib_binet(0)
101101
[0]
102102
>>> fib_binet(1)

0 commit comments

Comments
 (0)