Skip to content

Merge Fibonacci files #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianyizheng02 opened this issue Nov 1, 2021 · 1 comment · Fixed by #5738
Closed

Merge Fibonacci files #5735

tianyizheng02 opened this issue Nov 1, 2021 · 1 comment · Fixed by #5738

Comments

@tianyizheng02
Copy link
Contributor

As shown by issues #5665 and #5733, there are apparently multiple files for calculating the Fibonacci sequence, namely dynamic_programming/fibonacci.py and maths/fibonacci.py. There's also a third file, maths/fibonacci_sequence_recursion.py, that's not mentioned in the previous issues, and there might be more that I haven't spotted yet. Each of these files provides different algorithms for calculating the sequence.

I feel like some if not all of these files should be combined into one file. It'd not only be more convenient, but it'd also be easier to compare the algorithms against one another.

@tianyizheng02
Copy link
Contributor Author

I've merged maths/fibonacci.py and maths/fibonacci_sequence_recursion.py, but feel free to contribute if other Fibonacci files need to be merged as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant