This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
22
contributors
Commits on May 17, 2019
Commits on May 23, 2019
Commits on May 30, 2019
Commits on May 31, 2019
Commits on Jun 3, 2019
-
fix: handle entry points with custom output filename like output.file…
…name: "[name].custom.js"
-
-
fix: throw errors when the compilation state is not valid in order to…
… make the investigation easier
Commits on Jun 4, 2019
-
fix: do not include hot updates when generating requires in entry fil…
…es (they have to be required and processed by the Webpack runtime)
Commits on Jun 5, 2019
-
Co-Authored-By: Kristian Dimitrov <kddimitrov@progress.com>
Commits on Jun 6, 2019
-
-
fix: handle file dependencies in non root entry modules (e.g. tns_mod…
…ules/tns_core_modules/inspector_modules)
Commits on Jun 7, 2019
Commits on Jun 11, 2019
Commits on Jun 12, 2019
-
Merge branch 'release' into fatme/mrm
# Conflicts: # CHANGELOG.md # package.json
-
Merge pull request #931 from NativeScript/tachev/androidx
fix: migrate demo apps to android x
-
fix: emit inspector_modules as a module
This entry point does not resolve when transpiling `tns-core-modules`.
Commits on Jun 13, 2019
Commits on Jun 16, 2019
Commits on Jun 19, 2019
-
feat: introduce webpack only workflow (#882)
* fix: don't provide fake paths to the {N} CLI - relative to the `app` folder * feat: remove not needed hooks * feat: remove webpack compiler logic * fix: don't copy app_resources to the platforms folder * fix: respect --env.verbose * feat: respect production mode based on release option Implements: #911 * fix: watch platform specific files from node_modules Rel to: NativeScript/nativescript-cli#4480 * fix: don't emit absolute webpack's runtime files Previously we needed to emit files with full paths as {N} CLI relies on this and expected them in a such format. With the changes for "webpack-only" mode, {N} CLI expects only relative paths. So we need to fix this in order to ensure that runtime.js file will not be transferred on device on change in hmr mode. * fix: don't process runtime.js files We needed a special processing for `runtime.js` files as we excluded them when transferring the files on device. As the CLI is filtering and emit only hot-update files we don't need this logic anymore. * fix: emit runtime files and entry point files * fix: update webpack config files of demo apps * fix: don't use short imports in demo apps * fix: update dependencies of demo apps so they are compatible with 6.0 release
Commits on Jun 21, 2019
-
fix: follow the symlinks in JavaScript apps (#941)
We are already following the symlinks in TypeScript, Angular and Vue apps. It allows the plugin developers to link and develop their plugins directly in a JavaScript demo application
-
fix: fix hmr for platform specific files in linked plugins (#946)
* fix: override correctly webpack's watchFileSystem * fix: remove ExtraWatchWebpackPlugin from config files * chore: update demo apps
Commits on Jun 25, 2019
Commits on Jun 26, 2019
-
fix: inject app.css file from unit-test-runner on test command (#949)
Currently the app.css file from unit-test-runner is not included in bundle/vendor files on test command so the application remains without app.css file. The `tns-core-modules` shows an error in this situation with the in their latest next versions: ``` JS: Error: Could not load CSS from ./app.css: Error: com.tns.NativeScriptException: Failed to find module: "./app.css", relative to: app// JS: com.tns.Module.resolvePathHelper(Module.java:146) JS: com.tns.Module.resolvePath(Module.java:55) JS: com.tns.Runtime.callJSMethodNative(Native Method) JS: com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1212) JS: com.tns.Runtime.callJSMethodImpl(Runtime.java:1092) JS: com.tns.Runtime.callJSMethod(Runtime.java:1079) JS: com.tns.Runtime.callJSMethod(Runtime.java:1059) JS: com.tns.Runtime.callJSMethod(Runtime.java:1051) JS: com.tns.NativeScriptActivity.onCreate(NativeScriptActivity.java:19) JS: android.app.Activity.performCreate(Activity.java:7136) JS: android.app.Activity.performCreate(Activity.java:7127) JS: android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271) JS: android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2893) JS: android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048) JS: android.app.servertransac... ``` So we need to inject app.css in order to prevent this error :)
Commits on Jun 27, 2019
-
-
fix: hmr should work with uglify (#953)
Currently `hmr` with `--env.uglify` is not working as the uglifier touches all files. This leads to emit of files that are not hot updates. When CLI finds such files, it decides hmr is not successful and restarts the application. However, some of the emitted files are not actully changed. These emitted (and not changed) files are chunks of the entry points - as we are with HMR if there's an actual change for them, we'll receive hot-update files. Currently there's a logic to skip all emitted entry points and webpack runtime files (`runtime.js`) when we are with HMR. To fix the current issue, extend this logic to skip emitted chunks of entry points as well when we are with HMR and there's no hot-update for them.
Commits on Jun 28, 2019
-
refactor: fix deprecated APIs (#954)
* refactor: fix onCreate() deprecated API call * chore: update apps
-
fix: fix app.css file path on windows machines
Currently `tns test` command on windows throws the following error: ``` ERROR in ./app.js Module not found: Error: Can't resolve '.. ode_modules ativescript-unit-test-runnerapp.css' in 'C:\Jenkins\workspace\master-cli-test-windows\TestApp\app' @ ./app.js 12:93-157 Webpack compilation complete. { Error: Executing webpack failed with exit code 2. at DevicesService.<anonymous> (C:\Jenkins\workspace\master-cli-test-windows\node_modules\nativescript\lib\common\mobile\mobile-core\devices-service.js:368:38) at Generator.throw (<anonymous>) at rejected (C:\Jenkins\workspace\master-cli-test-windows\node_modules\nativescript\lib\common\mobile\mobile-core\devices-service.js:11:65) at process._tickCallback (internal/process/next_tick.js:68:7) allErrors: [ { Error: Executing webpack failed with exit code 2. at ChildProcess.childProcess.on (C:\Jenkins\workspace\master-cli-test-windows\node_modules\nativescript\lib\services\webpack\webpack-compiler-service.js:107:39) at ChildProcess.emit (events.js:189:13) at maybeClose (internal/child_process.js:970:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5) code: 2, deviceIdentifier: 'emulator-5562' ``` -
Merge pull request #955 from NativeScript/fatme/fix-css-file-windows
fix: fix app.css file path on windows machines
Commits on Jun 30, 2019
-
fix: don't restart application when lazy loaded code is changed in an…
…gular app with uglify option Currently there is a logic that gets all runtime files and entry point files from webpack compilation. These files are needed to CLI in order to decides if the application should be restarted or refreshed on device(when there is at least one file that is not hot update file, CLI restarts the application). However, this logic doesn't work for lazy loaded modules in angular application as they are reported neither entry point files nor runtime files. Lazy loaded modules are directly injected into webpack compilation using the hooks of ContextModuleFactory - https://github.com/angular/ngtools-webpack-builds/blob/39ccb0b487e92a7ac4330ff9db821337b7aa5c45/src/angular_compiler_plugin.js#L516. This PR fixes the behavior with lazy loaded files as it gets all chunks produced from webpack compilation and omits hot-update.js files from them. Chunk files are all files except hot update files. Chunk files are: `runtime.js`, `tns_modules/inspector-modules.js`, `bundle.js`, `vendor.js` and all lazy loaded modules. When a files is changed in hmr mode, <hash>.hot-update.js file is included into chunk files. This way we don't need to separate the files to entry point, runtime, lazy loaded and others. We just need to omit <hash>.hot-update.js file from chunk files from webpack compilation.
Commits on Jul 1, 2019
-
fix: create PropertyAssignment instead of string literal (Identifier)…
… when modifying the NgModule - in some cases (e.g. when there is a decomposition in another NgModule property), the TypeScipt program is trying to read `node.name.kind` on each property causing an exception for Identifiers)
Commits on Jul 2, 2019
-
feat(hooks): improve hooks handling (#961)
* fix(preuninstall): add preuninstall script to remove old hooks During migration from one version to another or when the plugin is removed from application we need to remove its hooks. This is usually done in preuninstall script, however, it was missing until now. This causes several issues when the version is updated as old hooks remain, but they may not be valid anymore. * fix(postinstall): remove old hooks As in 1.0.0 and CLI 6.0 we've changed the way nativescript-dev-webpack interacts with CLI, we need to remove hooks from previous nativescript-dev-webpack versions and use new ones. Usually this should happen with preuninstall script of the old version that removes the hooks. However, our current live version does not have such logic, so implement this in the postinstall of the current version. This way we try to ensure the current plugin will work correctly. * feat(hooks): add before-checkForChanges hook Add before-checkForChanges hook to prevent users from using the current version of the plugin with CLI 5.x.x or older. These two versions are incompatible, so add an error in case older CLI is used.
-
Merge pull request #957 from NativeScript/fatme/fix-ng-uglify
fix: don't restart application when lazy loaded code is changed in angular app with uglify option
Commits on Jul 3, 2019
-
fix: allow overriding the
global.processobject from both the app a……nd the plugins By default it will be undefined but the plugins and the app developers will be able to polyfill it. We had the same behavior with the Legacy Workflow.
There are no files selected for viewing