This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: stop generating .d.ts on TS compilation #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case `declaration` is set to true in `tsconfig.json` file, the webpack watcher goes in indefinite loop as each change of .ts file leads to generation of new .d.ts files which are also detected by webpack. To prevent this, ensure declaration is set to false in all compilation cases.
DimitarTachev
approved these changes
Jun 3, 2019
|
Merging with red tests as we know this PR is not causing them. |
Fatme
pushed a commit
that referenced
this pull request
Jun 6, 2019
* release: cut the 0.24.0 release (#916) chore: manually update CHANGELOG for release from 0.22.0 to 0.24.0 * fix: stop generating .d.ts on TS compilation (#919) In case `declaration` is set to true in `tsconfig.json` file, the webpack watcher goes in indefinite loop as each change of .ts file leads to generation of new .d.ts files which are also detected by webpack. To prevent this, ensure declaration is set to false in all compilation cases. * fix: move the type check to a child process in order to make it faster in bigger apps and unify the hmr and no-hmr experience. (#926)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
declarationis set to true intsconfig.jsonfile, the webpack watcher goes in indefinite loop as each change of .ts file leads to generation of new .d.ts files which are also detected by webpack.To prevent this, ensure declaration is set to false in all compilation cases.
PR Checklist
What is the current behavior?
Check related issue.
What is the new behavior?
Transpilation is working correctly.
Fixes issue #823