This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: introduce webpack only workflow #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Fatme
force-pushed
the
feature/webpack-only
branch
from
5aa41c9 to
33c2134
Compare
Fatme
force-pushed
the
feature/webpack-only
branch
3 times, most recently
from
2a6e203 to
5081c19
Compare
Fatme
force-pushed
the
feature/webpack-only
branch
2 times, most recently
from
945047e to
83f9cc0
Compare
|
test --ignore SHOULD_INSTALL_CLI branch_nativescript#feature/webpack-only |
|
test SHOULD_INSTALL_CLI branch_nativescript#feature/webpack-only |
|
test SHOULD_INSTALL_CLI branch_nativescript#feature/webpack-only groceries api23 ios11 |
|
test SHOULD_INSTALL_CLI branch_nativescript#feature/webpack-only groceries api23 ios11 --ignore |
|
test use_custom_cli branch_nativescript#feature/webpack-only groceries api23 ios11 --ignore |
|
test use_custom_cli branch_nativescript#feature/webpack-only |
Previously we needed to emit files with full paths as {N} CLI relies on this and expected them in a such format. With the changes for "webpack-only" mode, {N} CLI expects only relative paths. So we need to fix this in order to ensure that runtime.js file will not be transferred on device on change in hmr mode.
We needed a special processing for `runtime.js` files as we excluded them when transferring the files on device. As the CLI is filtering and emit only hot-update files we don't need this logic anymore.
Fatme
force-pushed
the
feature/webpack-only
branch
from
83f9cc0 to
0b48eb3
Compare
|
test use_custom_cli branch_nativescript#feature/webpack-only |
1 similar comment
|
test use_custom_cli branch_nativescript#feature/webpack-only |
DimitarTachev
approved these changes
Jun 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel to: #911
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].