fix: handle entry points with custom output filename #922

DimitarTachev · 2019-06-03T12:23:01Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the [CLA].
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

When a custom filename is set in the Webpack output property (e.g. output.file…name: "[name].custom.js"), the plugin is throwing an exception.

The custom filenames are properly handled.

…name: "[name].custom.js"

plugins/GenerateNativeScriptEntryPointsPlugin.js

… make the investigation easier

fix: handle entry points with custom output filename like output.file…

274ff53

…name: "[name].custom.js"

cla-bot bot added the cla: yes label Jun 3, 2019

rosen-vladimirov approved these changes Jun 3, 2019

View reviewed changes

plugins/GenerateNativeScriptEntryPointsPlugin.js Outdated Show resolved Hide resolved

DimitarTachev added 2 commits June 3, 2019 16:33

fix: avoid affecting the source maps by inserting new lines

23675a4

fix: throw errors when the compilation state is not valid in order to…

3aef461

… make the investigation easier

rosen-vladimirov approved these changes Jun 3, 2019

View reviewed changes

DimitarTachev merged commit 48b26f4 into master Jun 3, 2019

DimitarTachev deleted the tachev/fix-custom-output branch June 3, 2019 14:15