fix: do not add inspector_modules entry when core modules are an external module #936

DimitarTachev · 2019-06-13T07:44:34Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the [CLA].
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

…rnal module

templates/webpack.angular.js

fix: do not add inspector_modules entry when core modules are an exte…

e0cd8c1

…rnal module

cla-bot bot added the cla: yes label Jun 13, 2019

Fatme reviewed Jun 13, 2019

View reviewed changes

templates/webpack.angular.js Show resolved Hide resolved

Fatme approved these changes Jun 13, 2019

View reviewed changes

rosen-vladimirov approved these changes Jun 13, 2019

View reviewed changes

DimitarTachev merged commit fc4e415 into master Jun 13, 2019

DimitarTachev deleted the tachev/preview-ios-inspector branch June 13, 2019 12:51