[Doc FR]: Some update from EN version #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
# Conflicts: # docs/fr/api/components/TransitionGroupStub.md # docs/fr/api/components/TransitionStub.md # docs/fr/api/config.md # docs/fr/api/options.md # docs/fr/guides/dom-events.md # docs/fr/guides/getting-started.md # docs/fr/guides/using-with-vuex.md Signed-off-by: Bruno Lesieur <[email protected]>
|
Thanks for the PR 😀 Can you fix the failing linting test please |
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
posva
requested changes
Dec 8, 2017
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| * [mount (EN)](./mount.md) | |||
| * [shallow (EN)](./shallow.md) | |||
| * [Options de montage (EN)](./options.md) | |||
| * [Mounting Options (EN)](./options.md) | |||
There was a problem hiding this comment.
Volontaire, je traduirais quand la page sera traduite. Bien vu :)
docs/fr/guides/getting-started.md
Outdated
| @@ -114,7 +114,7 @@ Si vous avez toujours besoin de `nextTick` dans vos fichiers de tests, faites at | |||
|
|
|||
| ```js | |||
| // ceci ne sera pas intercepté | |||
| it('pas d'interception, (done) => { | |||
| it('pas d\'interception, (done) => { | |||
There was a problem hiding this comment.
autant faire avec "pas d'interception"
posva
requested changes
Dec 8, 2017
docs/fr/guides/getting-started.md
Outdated
|
|
||
| ```js | ||
| // ceci ne sera pas intercepté | ||
| it('pas d\'interception', (done) => { |
There was a problem hiding this comment.
plutôt entre guillemets doubles pour les guillemets simples
Signed-off-by: Bruno Lesieur <[email protected]>
|
@posva Are you happy with the changes? |
posva
approved these changes
Jan 2, 2018
|
I resolved the conflict by removing the clone option, hope I didn't mess it up and sorry for the delay. If I ever take more than 1 week to review something, please ping me 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @eddyerburgh! Some update in FR doc from last EN update.