Add warning about scoped Slot implementation #1212

LinusBorg · 2019-04-19T07:59:50Z

No description provided.

docs/api/options.md

correct typo Co-Authored-By: LinusBorg <[email protected]>

eddyerburgh · 2019-04-24T07:12:36Z

Thanks @LinusBorg . Can you run prettier to fix the formatting issue?

LinusBorg · 2019-04-24T10:47:15Z

@eddyerburgh

when i run prettier on the whole repo (yarn format) it changes >200 files.
When I run it on just the docs file (yarn prettier --no-semi --single-quote --write "./docs/api/options") it also changes around 20 other things, mostly turning - into* ` for lists.

No idea why?

* docs: update russian translation * style: format docs pages * chore(docs): typo

fixes #1223

BREAKING CHANGE: html output will now be formatted

winniehell · 2019-06-05T21:09:53Z

@LinusBorg Just a wild guess but maybe #1247 helps here. 🤔

Elements that are hidden via the HTML `hidden` attribute were being reported as being visible by the `isVisible()` method, even though they were not actually visible in the DOM.

fixes #1253

Fixes #1275

feat: Store selector in Wrapper.find() / .findAll()

Previously wrapper.trigger('keydown', { keyCode: 65 }) would trigger a keydown event with a keyCode of 0. This commit fixes that bug. PR closes #1285 PR closes #1295

Selecting already-selected radio buttons or checking already-checked checkboxes should not trigger events.

Older versions of Vue use the `click` DOM event for updating radio/checkbox `v-model`s.

Co-Authored-By: Adrià Fontcuberta <[email protected]>

…iling fix: use the keyCodes provided in options from wrapper.trigger

Docs: added example usage for localVue

chore: remove gh-pages

fix: Ensure setChecked() and setSelected() only trigger DOM events when state is changed (fix #1339)

correct typo Co-Authored-By: LinusBorg <[email protected]>

…js/vue-test-utils into LinusBorg-docs-scopedSlots-1

lmiller1990 · 2020-01-03T07:12:01Z

I tried to rebase and encountered the same problem described above, but did not notice until pushing the commits. So I just made a fresh fork of dev and copied the content over. It's here: #1389.

Going to close this one and get the other one merged.

Add warning about scoped Slot implementation (#1212)

Alexandre Bonhomme and others added 2 commits January 14, 2019 17:18

docs(mocha-webpack): replace mocha-webpack by mochapack fork

57aab16

Add warning about scoped Slot implementation

64caba7

LinusBorg added the docs label Apr 19, 2019

schumilin and others added 2 commits April 23, 2019 07:49

docs: update Karma docs link (#1208)

a433c91

docs(zh): update translation (#1194)

a523085

wiese reviewed Apr 23, 2019

View reviewed changes

docs/api/options.md Outdated Show resolved Hide resolved

Update docs/api/options.md

aeb1b49

correct typo Co-Authored-By: LinusBorg <[email protected]>

LinusBorg and others added 10 commits April 24, 2019 12:50

adjust formatting

ff7d2f0

docs: update Russian translation (#1215)

ecfe228

* docs: update russian translation * style: format docs pages * chore(docs): typo

refactor(types): use Component definition from Vue core (#1213)

1701b30

docs: add example for trigger with modifier keys (#1203)

a802b32

docs(wrapper): сlarify attachedToDocument meaning in docs (#1214)

23e496b

fix: polyfill Element.matches for IE < 11 (#1230)

5e04331

fixes #1223

fix(types): allow false as a component stub value (#1231)

2a4c6ef

feat: add option to pretty print html components (#1229)

99336c4

BREAKING CHANGE: html output will now be formatted

docs: update common-tips.md (#1249)

10ea249

chore: use config file for Prettier (#1247)

8a74a15

stevegrunwell and others added 10 commits June 12, 2019 09:26

fix: respect "hidden" attributes in isVisible() (#1257)

950763f

Elements that are hidden via the HTML `hidden` attribute were being reported as being visible by the `isVisible()` method, even though they were not actually visible in the DOM.

docs(zh): updated (#1263)

6d27483

docs: update common-tips.md (#1290)

b3623f7

docs: correct $nexTick -> $nextTick (#1282)

a65da38

fix: add $set scoped slot helper (#1287)

a9eea7b

fixes #1253

Fixed typo (#1296)

9dc90a3

docs: fix Lerna link in CONTRIBUTING.md (#1299)

7968540

chore: bump lodash to ^4.17.15 to fix vulnerability (#1297)

ad602fc

Fixes #1275

Merge branch 'dev' into dev

393b842

docs(cn): fix error in testing-async-component.md (#1343)

a0f35d2

JessicaSachs and others added 25 commits December 18, 2019 13:15

Merge pull request #1248 from winniehell/winniehell-wrapper-selector

7c7b949

feat: Store selector in Wrapper.find() / .findAll()

fix: use the keyCodes provided in options from wrapper.trigger

9aa178c

Previously wrapper.trigger('keydown', { keyCode: 65 }) would trigger a keydown event with a keyCode of 0. This commit fixes that bug. PR closes #1285 PR closes #1295

test: ensure Wrapper.setChecked() is a no-op for checked checkboxes

771075f

test: ensure Wrapper.setChecked() is a no-op for selected radios

1ee1fa0

Selecting already-selected radio buttons or checking already-checked checkboxes should not trigger events.

fix: ensure Wrapper.setChecked() idempotence

562bf11

test: fix Wrapper.setChecked() test compatibility

f63eda2

Older versions of Vue use the `click` DOM event for updating radio/checkbox `v-model`s.

test: ensure Wrapper.setSelected() idempotency

e229e37

fix: ensure Wrapper.setSelected() idempotency

90a7ea8

style: fix linting errors

8ec4bfc

test: follow convention for scenario statements

cdc0762

Co-Authored-By: Adrià Fontcuberta <[email protected]>

Merge pull request #1378 from vuejs/fix/issue-1285-custom-keycodes-fa…

6fdc179

…iling fix: use the keyCodes provided in options from wrapper.trigger

Fix failing formatter

d9e2663

docs(mocha-webpack): replace mocha-webpack with mochapack

e33a797

docs: added example usage for localVue

0f91426

Merge pull request #1381 from NataliaTepluhina/docs/fix-localVue-example

089a6ca

Docs: added example usage for localVue

docs: Add example for 'listeners' mount option

3f9aebf

(docs): include guide about testing with node

9a1fc6d

chore: remove gh-pages

0dd7458

Merge pull request #1388 from vuejs/chore/remove-gh-pages

56573b1

chore: remove gh-pages

Merge pull request #1380 from vvanpo/set-selected

916b07f

fix: Ensure setChecked() and setSelected() only trigger DOM events when state is changed (fix #1339)

Add warning about scoped Slot implementation

d70627d

Update docs/api/options.md

0aab30d

correct typo Co-Authored-By: LinusBorg <[email protected]>

adjust formatting

ba66e13

Merge branch 'LinusBorg-docs-scopedSlots-1' of https://github.com/vue…

a23860b

…js/vue-test-utils into LinusBorg-docs-scopedSlots-1

(docs): run prettier

b4a30f6

lmiller1990 mentioned this pull request Jan 3, 2020

Add warning about scoped Slot implementation (#1212) #1389

Merged

lmiller1990 closed this Jan 3, 2020

lmiller1990 added a commit that referenced this pull request Jan 3, 2020

Merge pull request #1389 from vuejs/scopedslots-tip

7b267b0

Add warning about scoped Slot implementation (#1212)

lmiller1990 deleted the LinusBorg-docs-scopedSlots-1 branch January 3, 2020 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warning about scoped Slot implementation #1212

Add warning about scoped Slot implementation #1212

LinusBorg commented Apr 19, 2019

eddyerburgh commented Apr 24, 2019

LinusBorg commented Apr 24, 2019

winniehell commented Jun 5, 2019

lmiller1990 commented Jan 3, 2020 •

edited

Loading

Add warning about scoped Slot implementation #1212

Add warning about scoped Slot implementation #1212

Conversation

LinusBorg commented Apr 19, 2019

eddyerburgh commented Apr 24, 2019

LinusBorg commented Apr 24, 2019

winniehell commented Jun 5, 2019

lmiller1990 commented Jan 3, 2020 • edited Loading

lmiller1990 commented Jan 3, 2020 •

edited

Loading