Skip to content

refactor(types): use Component definition from Vue core #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2019
Merged

refactor(types): use Component definition from Vue core #1213

merged 1 commit into from
Apr 27, 2019

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Apr 19, 2019

Reason: TODO to replace types, looks like it's already merged in Vue.

eddyerburgh
eddyerburgh approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@vue-bot
Copy link

vue-bot commented Apr 27, 2019

Hey @sh7dm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@eddyerburgh eddyerburgh merged commit 1701b30 into vuejs:dev Apr 27, 2019
@dsseng dsseng deleted the types/use-vue-component branch April 27, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsseng @vue-bot @eddyerburgh