Skip to content

Docs: added example usage for localVue #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2019

Conversation

NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented Dec 21, 2019

What does this PR do?

I've extended an example for createLocalVue API, adding localVue.use call.

Why this is important?

People tend to take examples very literally, copy-pasting them to their codebase without any additions. Results could be really dramatic: I've just found out 120 files of GitLab codebase create localVue instances and inject them via shallowMount for no reason. This PR is trying to show the real need for creating localVue in the test case

@JessicaSachs JessicaSachs merged commit 089a6ca into vuejs:dev Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants