Update serverless-blog.md (typo) #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinjiang
commented
Mar 19, 2018
| @@ -115,18 +115,17 @@ Then create `components/BlogHome.vue` which will be your blog homepage that list | |||
| } | |||
| } | |||
| </script> | |||
| Display the result | |||
There was a problem hiding this comment.
The text "Display the result" seems meaningless so I removed it.
| @@ -88,7 +89,7 @@ export default new Router({ | |||
|
|
|||
| Then create `components/BlogHome.vue` which will be your blog homepage that lists your most recent posts. | |||
|
|
|||
| ```javascript | |||
| ```html | |||
There was a problem hiding this comment.
The code snippet seems should be used with Vue syntax, not JavaScript. And as the vue syntax is not supported in Hexo, so I changed it into html as a downgrade syntax.
| @@ -105,7 +106,6 @@ Then create `components/BlogHome.vue` which will be your blog homepage that list | |||
| page: 1, | |||
| page_size: 10 | |||
| }).then((res) => { | |||
| // console.log(res.data) | |||
There was a problem hiding this comment.
Not necessary because it has a real job to do below, so removed.
Jinjiang
commented
Mar 19, 2018
| @@ -4,8 +4,6 @@ type: cookbook | |||
| order: 5 | |||
| --- | |||
|
|
|||
| # Create a CMS-Powered Blog Using Vue.js | |||
There was a problem hiding this comment.
Duplicated with the title in the metadata. So removed.
sdras
reviewed
Mar 19, 2018
src/v2/cookbook/serverless-blog.md
Outdated
|
|
||
| <template> | ||
| <div id="blog-home"> | ||
| <h1>{{ page_title }}</h1> | ||
| <!-- Create v-for and apply a key for Vue. Example is using a combination of the slug and index --> | ||
| <!-- Create `v-for` and apply a `key` for Vue. Here is using a combination of the slug and index. --> |
There was a problem hiding this comment.
"Here is using" isn't grammatically correct. It should either be "This example is..." or "Here we are using"
sdras
reviewed
Mar 19, 2018
|
|
||
| <p class="tip">Be aware, that using the component this way will mean that the lifecycle hooks of the component will not be called. Visit the Vue.js docs to learn more about [Dynamic Route Matching](https://router.vuejs.org/en/essentials/dynamic-matching.html)</p> | ||
| <p class="tip">Be aware, that using the component this way will mean that the lifecycle hooks of the component will not be called. Visit the Vue Router's docs to learn more about [Dynamic Route Matching](https://router.vuejs.org/en/essentials/dynamic-matching.html)</p> |
|
There's only one change needed, otherwise, all great changes, thank you! |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.