-
Notifications
You must be signed in to change notification settings - Fork 533
v2.3.0 release #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@lionel-bijaoui I just ran into an interesting issue. I merged the updates and tried to use them in my current project and started getting an error. Here's what I'm doing (it's a bit odd, perhaps).
With that import statement, I then use
This let's me use The updates in this PR broke this, as the Think we can work on a way of exposing all of the core fields so they can be used as base classes for custom fields? |
@zoul0813 Ok, so, the thing is for the v3, VFG will not be bundled with fields at all (maybe a tool will allow for easy bundle making, but this is for later). So, I started to test a config/repo for the future individual fields (https://github.com/vue-generators/vfg-field-checkbox <-- not functional right now). EDIT: I have a temporary solution for you, I understand why it is not working |
No fields at all, including the "core" standard fields such as Input, Select, Checkbox, etc? I think VFG should come with the core fields, but not the optional ones. And yeah, I'm aware that my use case was unique and was a hack. I got it working, I just updated the code to access the formGroup component exposed by formGenerator, then grabbed the fieldInput from the formGroup's exposed components. I just think that any stock fields should be publicly exposed, so they can be used as base classes ... similar to |
No core at all, just the engine. Of course, we could provide a special version (pack ?) with some fields that install in bulk, but i would prefer a tool to build pack, or even better build schema with a GUI (CLI also ?). This is my vision for the future of VFG. I understand that this is a big change from the current system, but if you look at other lib (babel for example), it doesn't seem so strange and start to make a lot of sense as to why take this approach. |
Sounds good. |
@lionel-bijaoui found a bug, the I'm submitting a PR to fix that, and then afterwards ... I think v2.3.0 is good to be released? |
* hotfix/fix-model-updated-event: vue-generators#472 - fix `model-updated` event Fix bug in IE11 and Edge
yes |
I'm wondering when the v2.3.0 will be released? I'd like to make use of the recently introduced html in labels, it's going to help me out no end. |
@lionel-bijaoui Travis is still failing, I can't reproduce this failure on my box ... can you? |
The error that travis is reporting seems to be caused by babel-eslint from what I can tell - babel/babel-eslint#530 |
Has there been any further progress with this issue? Anything I could do to help? |
Yes, I managed to fix the issue in the v3 branch (#481). A mix of yarn and npm version. |
Excellent! Does this mean waiting for v3, or will the fixes from the v3 branch be carried over to master to allow 2.3 to be released? |
I will try to fix Travis in 2.3 |
Apologies, I’ve been stuck in production release mode on my latest project and haven’t had time to work on VFG... will hopefully be getting back to VFG in the next week or two as my next project will rely heavily on it. |
@lionel-bijaoui did you make any headway fixing Travis in 2.3? |
@tomdickie no yet, I'm on holidays |
@tomdickie @zoul0813 Travis is fixed in v2 branch |
Excellent news, thanks for the update @lionel-bijaoui will that change ultimately make its way to the npm module? |
I don't know how to create a full release (npm and all), but I think @zoul0813 know how to. |
Sorry guys, I've been busy with work the past few weeks. I merged all of the latest stuff into my fork yesterday and am testing it now. If all goes well, I'll make a PR and get 2.3.0 out ASAP. |
Been a while, but assuming I did everything correctly ... npm should have v2.3.0 available shortly. |
NPM still show 2.2.2 as latest. How long is it supposed to take? |
All done - there was an issue with the CI script. |
Travis doesn’t build those before it bundles for npmjs? I can add dist files with 2.3.1 tomorrow - yeah. |
…o v3 * 'v3' of https://github.com/icebob/vue-form-generator: vue-generators#472 - fix `model-updated` event Code refactoring and fix codacity issues Alternative solution to expose embeded fields Fix fields exposition (temporary solution) Fix bug in IE11 and Edge Fix version number Fix URL, rename and move mixinsUtils.js, modify a comment Rework of formGenerator to use a component Allow HTML for label & hint Fixed vue-generators#380 - Added vue-multiselect noResult slot option Bumped [email protected] for Node 10 Compatibility add vfg-field-array into the readme Return entire VFG instance with validation event Include UID for emitted form validation events
This issue is for tracking the discussion related to releasing v2.3.0
For example, I get the following output when running the v2.3.0 tests, looks like the majority of "errors" are related to fieldSelectEx.vue tests.
The text was updated successfully, but these errors were encountered: