adding bootstrap class support #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the scss in the formGroup.vue file to target elements that do not have a class that starts with 'col-' and set their width to 100%. Removed 'width:100%' from the form-group selector.
|
Hello @averagejoe77 , thank you for your PR ! |
lionel-bijaoui
pushed a commit
to lionel-bijaoui/vue-form-generator
that referenced
this pull request
Sep 24, 2018
lionel-bijaoui
pushed a commit
to lionel-bijaoui/vue-form-generator
that referenced
this pull request
Sep 25, 2018
lionel-bijaoui
pushed a commit
to lionel-bijaoui/vue-form-generator
that referenced
this pull request
Sep 25, 2018
lionel-bijaoui
pushed a commit
to lionel-bijaoui/vue-form-generator
that referenced
this pull request
Sep 28, 2018
3 tasks
lionel-bijaoui
added a commit
that referenced
this pull request
Sep 28, 2018
Implement changes from PR #486
I am sorry I thought you guys would have tested and run the build before this got merged. I only updated the .vue file but did not run the build. The latest branch (2.3.0) with this PR merged in does not contain the actual change in the css file. Do you want me to create a new PR with the actual css files getting updated? |
|
@averagejoe77 Travis CI should have handled that - looks like something went wrong. @lionel-bijaoui have any thoughts? |
|
Yep - I’ll correct that with 2.3.1, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the scss in the formGroup.vue file to target elements that do not have a class that starts with 'col-' and set their width to 100%. Removed 'width:100%' from the form-group selector.