Skip to content

Build size optimization #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2018
Merged

Build size optimization #498

merged 1 commit into from
Oct 2, 2018

Conversation

lionel-bijaoui
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature
  • What is the current behavior? (You can also link to an open issue here)
    Bundle size are not fully optimized
  • What is the new behavior (if this is a feature change)?
    Use lodash-webpack-plugin for even better size
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No
  • Other information:
    • full 186 Ko -> 168 Ko
    • core 160 Ko -> 142 Ko

I did that to compare size in a fair way with the v3 branch

Build size optimization
b4e32ac 
- Use lodash-webpack-plugin for even better size
- full 186 Ko -> 168 Ko
- core 160 Ko -> 142 Ko
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling b4e32ac on lionel-bijaoui:build-size-optimization into d876955 on vue-generators:master.

@lionel-bijaoui lionel-bijaoui mentioned this pull request Oct 1, 2018
Closed
@lionel-bijaoui lionel-bijaoui merged commit 4656dda into vue-generators:master Oct 2, 2018
@lionel-bijaoui lionel-bijaoui deleted the build-size-optimization branch October 2, 2018 07:46
@zoul0813
Copy link
Member

zoul0813 commented Oct 2, 2018

@lionel-bijaoui do you want me to release this as v2.3.1?

@lionel-bijaoui
Copy link
Member Author

Yes

@zoul0813 zoul0813 mentioned this pull request Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob Awaiting requested review from icebob

@zoul0813 zoul0813 Awaiting requested review from zoul0813

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionel-bijaoui @coveralls @zoul0813