Skip to content

ODIN_II: Fix coverity issue CID 201694 #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2019
Merged

ODIN_II: Fix coverity issue CID 201694 #803

merged 1 commit into from
Jul 20, 2019

Conversation

j-b-1-7
Copy link
Contributor

@j-b-1-7 j-b-1-7 commented Jul 19, 2019

Description

Should resolve coverity issue CID 201694. Check the length of node->name before appending to buffer

How Has This Been Tested?

Odin pre-commit

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Jul 19, 2019
@jeanlego
Copy link
Contributor

This looks more like a workaround for the fact that it is using a statically sized buffer, I would move this to a dynamically growing buffer.
Can you raise an issue?
it is ok to merge as it fixed the original error, but this needs to be rethought.

@jeanlego jeanlego mentioned this pull request Jul 20, 2019
Closed
@jeanlego jeanlego merged commit f085d05 into verilog-to-routing:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-b-1-7 @jeanlego