Merge pull request #803 from j-b-1-7/odin_coverity_issue_201694

jeanlego · web-flow · commit f085d050cf3d · 2019-07-20T09:44:55.000-03:00
ODIN_II: Fix coverity issue CID 201694
diff --git a/ODIN_II/SRC/simulate_blif.cpp b/ODIN_II/SRC/simulate_blif.cpp
@@ -4226,7 +4226,8 @@ static char *get_mif_filename(nnode_t *node)
 {
 	char buffer[BUFFER_MAX_SIZE];
 	buffer[0] = 0;
-	strcat(buffer, node->name);
+	if(strlen(node->name) < BUFFER_MAX_SIZE)
+		strcat(buffer, node->name);
 
 	char *filename = strrchr(buffer, '+');
 	if (filename) filename += 1;

Original file line number	Diff line number	Diff line change
`@@ -4226,7 +4226,8 @@ static char get_mif_filename(nnode_t node)`
`4226`	`4226`	`{`
`4227`	`4227`	`char buffer[BUFFER_MAX_SIZE];`
`4228`	`4228`	`buffer[0] = 0;`
`4229`		`- strcat(buffer, node->name);`
	`4229`	`+ if(strlen(node->name) < BUFFER_MAX_SIZE)`
	`4230`	`+ strcat(buffer, node->name);`
`4230`	`4231`
`4231`	`4232`	`char *filename = strrchr(buffer, '+');`
`4232`	`4233`	`if (filename) filename += 1;`