Skip to content

Change QoR parsing configs to use the fixed channel width variant #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025

Conversation

AmirhosseinPoolad
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad commented Jun 12, 2025

Changes the parse_file attribute of tests that use fixed channel widths instead of doing the minimum channel width search to use vpr_fixed_chan_width.txt instead of vpr_standard.txt

@AmirhosseinPoolad AmirhosseinPoolad force-pushed the fixed_channel_parse_fix branch from d622e75 to cf091b6 Compare June 12, 2025 21:04
@AmirhosseinPoolad
Copy link
Contributor Author

AmirhosseinPoolad commented Jun 12, 2025

Since the parse_results.txt for some of the tests are going to be different, I need to update golden results for those tests. Here's a checklist to make sure I don't forget anything.

  • vtr_reg_strong
  • vtr_reg_strong_odin
  • vtr_reg_nightly_test1 (Did not actually regenerated anything. Only changed task was symbiflow but the test does not work and isn't in the tasklist)
  • vtr_reg_nightly_test1_odin (Same as above)
  • vtr_reg_nightly_test2
  • vtr_reg_nightly_test2_odin
  • vtr_reg_nightly_test4
  • vtr_reg_nightly_test4_odin
  • vtr_reg_nightly_test5
  • vtr_reg_nightly_test6
  • vtr_reg_valgrind (No pass requirements)
  • vtr_reg_weekly

@github-actions github-actions bot added the infra Project Infrastructure label Jun 12, 2025
@AmirhosseinPoolad
Copy link
Contributor Author

AmirhosseinPoolad commented Jun 12, 2025

Sorry to hijack the PR but since this is going to require regenerating a ton of golden results I made NightlyTestManual generate and upload them. I can remove the commit if you disagree. @AlexandreSinger FYI.

@AlexandreSinger
Copy link
Contributor

No worries @AmirhosseinPoolad , no one appears to be using it! Do please also update the golden results for some of the failing nightly tests while you are at it! 2 small ones were failing before! If not do not worry about it!

@AlexandreSinger AlexandreSinger mentioned this pull request Jun 16, 2025
5 tasks
@vaughnbetz
Copy link
Contributor

LGTM. I know you tell me some nightly tests results are broken before this change, but they are small ones where the QoR is just a bit out of date. Just go ahead and do a global golden results update for this change, as long as you're confident there are no real issues in the current QoR failures.

@AmirhosseinPoolad AmirhosseinPoolad force-pushed the fixed_channel_parse_fix branch 3 times, most recently from b997d1a to f73ad53 Compare June 17, 2025 13:36
Changes the parse_file attribute of tests that use fixed channel widths instead of doing the minimum channel width search to use vpr_fixed_chan_width.txt instead of vpr_standard.txt
@AmirhosseinPoolad AmirhosseinPoolad force-pushed the fixed_channel_parse_fix branch from f73ad53 to 071ad38 Compare June 17, 2025 13:36
@AmirhosseinPoolad AmirhosseinPoolad force-pushed the fixed_channel_parse_fix branch from c7fa1e4 to fa09d75 Compare June 17, 2025 15:49
@AmirhosseinPoolad AmirhosseinPoolad merged commit 5160a12 into master Jun 17, 2025
30 of 32 checks passed
@AmirhosseinPoolad AmirhosseinPoolad deleted the fixed_channel_parse_fix branch June 17, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants