Skip to content

Regenerate nightly test golden results #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

AmirhosseinPoolad
Copy link
Contributor

This PR regenerates all the golden results for vtr_reg_nightly_test1-7. To summarize, the reasons for doing this would be:

  • There were some unimportant failures on a limited number of circuits that needed new golden results
  • The way some test results were being parsed was wrong. Change QoR parsing configs to use the fixed channel width variant #3138 Fixed that but necessitated new golden results
  • The new[ly added to the tasklist] vtr_xilinx_qor test in vtr_reg_nightly_test2 had old and invalid golden results
  • Yosys upgrade which also changed a lot of results

Since we have a mostly clean slate otherwise, regenerating golden results should be safe. One potential issue is that this would leave the following commits untested:

image

Given that these commits are either things we want to do anyway e.g. yosys upgrade or they don't change VTR functionality in any way, I would not be too concerned about it.

Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for doing this Amir! This is somewhat healthy to do every so often so long as we verify that the large circuits that we care about do not regress in quality (which Logan already did when updating the Yosys version).

@AlexandreSinger AlexandreSinger merged commit 7dfdcc7 into master Jun 19, 2025
33 checks passed
@AlexandreSinger AlexandreSinger deleted the nightly_test_regen_all_golden branch June 19, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants