[CI] Upgraded Actions #2568
[CI] Upgraded Actions #2568
Conversation
AlexandreSinger
force-pushed
the
feature-upgrade-ci-actions
branch
from
9e9e62a to
7de3875
Compare
The Annotations section of the CI was full of deprecation warnings. Node.js 16 actions were deprecated. Upgraded setup-python, checkout, and upload-artifact to their most recent version. See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ v3 of upload-artifact was also deprecated. v4 claims to be 98% faster, however, may come with some breaking changes. Pertaining to us, artifacts cannot have the same name now and there is a limit of 500 artifacts. See: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ NOTE: Had to leave the nightly tests behind since the self-hosted machine does not support node20. Need to upgrade the machine in order to upgrade these actions.
AlexandreSinger
force-pushed
the
feature-upgrade-ci-actions
branch
from
7de3875 to
4dd51dd
Compare
|
@vaughnbetz What do you think about these changes? This has removed most of the warnings except for 1, which I put a comment in the CI code with a TODO regarding upgrading the self-hosted runners: This also made it easier to download artifacts for the nightly tests since it now separates them out into their own artifacts: |
|
Sounds great -- thanks! Merging these in. Upgrading the self-hosted ones before node 16 goes away forever is definitely a good idea too. Not sure what we have to do to make that happen, and if we need Herman's help (since it is on a google cloud machine). |
| @@ -71,9 +73,12 @@ jobs: | |||
| VTR_CMAKE_PARAMS: ${{ matrix.cmake }} | |||
| NUM_CORES: ${{ matrix.cores }} | |||
|
|
|||
| - uses: actions/upload-artifact@v3 | |||
| if: ${{ always() }} | |||
There was a problem hiding this comment.
I think this line should not have been removed.
There was a problem hiding this comment.
@AlexandreSinger : what do you think? Should this go back in?
There was a problem hiding this comment.
@soheilshahrouz @vaughnbetz My bad... I misunderstood what this was trying to do. Perhaps in the future we should consider a better keyword to use:
https://docs.github.com/en/actions/learn-github-actions/expressions#always
In the meantime I have raised a PR reverting this removal: PR #2583
The Annotations section of the CI was full of deprecation warnings:
Node.js 16 actions were deprecated. Upgraded setup-python, checkout, and upload-artifact to their most recent version. See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
v3 of upload-artifact was also deprecated. v4 claims to be 98% faster, however, may come with some breaking changes. Pertaining to us, artifacts cannot have the same name now and there is a limit of 500 artifacts. See:
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Upgrade summary:
NOTE: Had to leave the nightly tests behind since the self-hosted
machine does not support node20. Need to upgrade the machine in order to
upgrade these actions.