Skip to content

[CI] Upgraded Actions #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

[CI] Upgraded Actions #2568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/containers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:

- name: 🧰 Repository Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
submodules: 'true'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
triage:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/labeler@master
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
57 changes: 31 additions & 26 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ jobs:

steps:

# TODO: This runnner is running on a self-hosted CPU. In order to upgrade
# to v4, need to upgrade the machine to support node20.
- uses: actions/checkout@v3
with:
submodules: 'true'
Expand All @@ -71,9 +73,12 @@ jobs:
VTR_CMAKE_PARAMS: ${{ matrix.cmake }}
NUM_CORES: ${{ matrix.cores }}

- uses: actions/upload-artifact@v3
if: ${{ always() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should not have been removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexandreSinger : what do you think? Should this go back in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soheilshahrouz @vaughnbetz My bad... I misunderstood what this was trying to do. Perhaps in the future we should consider a better keyword to use:
https://docs.github.com/en/actions/learn-github-actions/expressions#always

In the meantime I have raised a PR reverting this removal: PR #2583

- name: Upload test results
# TODO: This runnner is running on a self-hosted CPU. In order to upgrade
# to v4, need to upgrade the machine to support node20.
uses: actions/upload-artifact@v3
with:
name: ${{matrix.test}}_test_results
path: |
**/results*.gz
**/plot_*.svg
Expand All @@ -92,10 +97,10 @@ jobs:
- { build_type: 'debug', verbose: '1' }
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand All @@ -122,10 +127,10 @@ jobs:
name: 'F: ${{ matrix.name }}'
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: ./.github/scripts/install_dependencies.sh

- name: Test
Expand All @@ -137,10 +142,10 @@ jobs:
runs-on: ubuntu-22.04
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand All @@ -156,10 +161,10 @@ jobs:
runs-on: ubuntu-22.04
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand Down Expand Up @@ -236,10 +241,10 @@ jobs:
name: 'R: ${{ matrix.name }}'
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand All @@ -255,7 +260,7 @@ jobs:
./run_reg_test.py ${{ matrix.suite }} -show_failures -j2

- name: Upload regression run files
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{matrix.name}}_run_files
path: |
Expand All @@ -266,7 +271,7 @@ jobs:
vtr_flow/**/*.r

- name: Upload regression results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{matrix.name}}_results
path: |
Expand All @@ -291,10 +296,10 @@ jobs:
name: 'S: ${{ matrix.name }}'
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'

Expand Down Expand Up @@ -325,10 +330,10 @@ jobs:
runs-on: ubuntu-22.04
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand All @@ -350,10 +355,10 @@ jobs:
runs-on: ubuntu-22.04
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand All @@ -376,10 +381,10 @@ jobs:
runs-on: ubuntu-22.04
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand Down Expand Up @@ -411,10 +416,10 @@ jobs:
name: 'B: ${{ matrix.name }}'
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand Down Expand Up @@ -447,10 +452,10 @@ jobs:
runs-on: ubuntu-22.04
steps:

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: 3.10.10
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'true'
- run: ./.github/scripts/install_dependencies.sh
Expand Down
Loading