Skip to content

Commit 4dd51dd

Browse files
[CI] Upgraded Actions
The Annotations section of the CI was full of deprecation warnings. Node.js 16 actions were deprecated. Upgraded setup-python, checkout, and upload-artifact to their most recent version. See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ v3 of upload-artifact was also deprecated. v4 claims to be 98% faster, however, may come with some breaking changes. Pertaining to us, artifacts cannot have the same name now and there is a limit of 500 artifacts. See: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ NOTE: Had to leave the nightly tests behind since the self-hosted machine does not support node20. Need to upgrade the machine in order to upgrade these actions.
1 parent efe7cc0 commit 4dd51dd

File tree

3 files changed

+33
-28
lines changed

3 files changed

+33
-28
lines changed

.github/workflows/containers.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
steps:
1717

1818
- name: 🧰 Repository Checkout
19-
uses: actions/checkout@v3
19+
uses: actions/checkout@v4
2020
with:
2121
submodules: 'true'
2222

.github/workflows/labeler.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
triage:
77
runs-on: ubuntu-latest
88
steps:
9-
- uses: actions/checkout@v3
9+
- uses: actions/checkout@v4
1010
- uses: actions/labeler@master
1111
with:
1212
repo-token: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/test.yml

Lines changed: 31 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ jobs:
5151

5252
steps:
5353

54+
# TODO: This runnner is running on a self-hosted CPU. In order to upgrade
55+
# to v4, need to upgrade the machine to support node20.
5456
- uses: actions/checkout@v3
5557
with:
5658
submodules: 'true'
@@ -71,9 +73,12 @@ jobs:
7173
VTR_CMAKE_PARAMS: ${{ matrix.cmake }}
7274
NUM_CORES: ${{ matrix.cores }}
7375

74-
- uses: actions/upload-artifact@v3
75-
if: ${{ always() }}
76+
- name: Upload test results
77+
# TODO: This runnner is running on a self-hosted CPU. In order to upgrade
78+
# to v4, need to upgrade the machine to support node20.
79+
uses: actions/upload-artifact@v3
7680
with:
81+
name: ${{matrix.test}}_test_results
7782
path: |
7883
**/results*.gz
7984
**/plot_*.svg
@@ -92,10 +97,10 @@ jobs:
9297
- { build_type: 'debug', verbose: '1' }
9398
steps:
9499

95-
- uses: actions/setup-python@v4
100+
- uses: actions/setup-python@v5
96101
with:
97102
python-version: 3.10.10
98-
- uses: actions/checkout@v3
103+
- uses: actions/checkout@v4
99104
with:
100105
submodules: 'true'
101106
- run: ./.github/scripts/install_dependencies.sh
@@ -122,10 +127,10 @@ jobs:
122127
name: 'F: ${{ matrix.name }}'
123128
steps:
124129

125-
- uses: actions/setup-python@v4
130+
- uses: actions/setup-python@v5
126131
with:
127132
python-version: 3.10.10
128-
- uses: actions/checkout@v3
133+
- uses: actions/checkout@v4
129134
- run: ./.github/scripts/install_dependencies.sh
130135

131136
- name: Test
@@ -137,10 +142,10 @@ jobs:
137142
runs-on: ubuntu-22.04
138143
steps:
139144

140-
- uses: actions/setup-python@v4
145+
- uses: actions/setup-python@v5
141146
with:
142147
python-version: 3.10.10
143-
- uses: actions/checkout@v3
148+
- uses: actions/checkout@v4
144149
with:
145150
submodules: 'true'
146151
- run: ./.github/scripts/install_dependencies.sh
@@ -156,10 +161,10 @@ jobs:
156161
runs-on: ubuntu-22.04
157162
steps:
158163

159-
- uses: actions/setup-python@v4
164+
- uses: actions/setup-python@v5
160165
with:
161166
python-version: 3.10.10
162-
- uses: actions/checkout@v3
167+
- uses: actions/checkout@v4
163168
with:
164169
submodules: 'true'
165170
- run: ./.github/scripts/install_dependencies.sh
@@ -236,10 +241,10 @@ jobs:
236241
name: 'R: ${{ matrix.name }}'
237242
steps:
238243

239-
- uses: actions/setup-python@v4
244+
- uses: actions/setup-python@v5
240245
with:
241246
python-version: 3.10.10
242-
- uses: actions/checkout@v3
247+
- uses: actions/checkout@v4
243248
with:
244249
submodules: 'true'
245250
- run: ./.github/scripts/install_dependencies.sh
@@ -255,7 +260,7 @@ jobs:
255260
./run_reg_test.py ${{ matrix.suite }} -show_failures -j2
256261
257262
- name: Upload regression run files
258-
uses: actions/upload-artifact@v3
263+
uses: actions/upload-artifact@v4
259264
with:
260265
name: ${{matrix.name}}_run_files
261266
path: |
@@ -266,7 +271,7 @@ jobs:
266271
vtr_flow/**/*.r
267272
268273
- name: Upload regression results
269-
uses: actions/upload-artifact@v3
274+
uses: actions/upload-artifact@v4
270275
with:
271276
name: ${{matrix.name}}_results
272277
path: |
@@ -291,10 +296,10 @@ jobs:
291296
name: 'S: ${{ matrix.name }}'
292297
steps:
293298

294-
- uses: actions/setup-python@v4
299+
- uses: actions/setup-python@v5
295300
with:
296301
python-version: 3.10.10
297-
- uses: actions/checkout@v3
302+
- uses: actions/checkout@v4
298303
with:
299304
submodules: 'true'
300305

@@ -325,10 +330,10 @@ jobs:
325330
runs-on: ubuntu-22.04
326331
steps:
327332

328-
- uses: actions/setup-python@v4
333+
- uses: actions/setup-python@v5
329334
with:
330335
python-version: 3.10.10
331-
- uses: actions/checkout@v3
336+
- uses: actions/checkout@v4
332337
with:
333338
submodules: 'true'
334339
- run: ./.github/scripts/install_dependencies.sh
@@ -350,10 +355,10 @@ jobs:
350355
runs-on: ubuntu-22.04
351356
steps:
352357

353-
- uses: actions/setup-python@v4
358+
- uses: actions/setup-python@v5
354359
with:
355360
python-version: 3.10.10
356-
- uses: actions/checkout@v3
361+
- uses: actions/checkout@v4
357362
with:
358363
submodules: 'true'
359364
- run: ./.github/scripts/install_dependencies.sh
@@ -376,10 +381,10 @@ jobs:
376381
runs-on: ubuntu-22.04
377382
steps:
378383

379-
- uses: actions/setup-python@v4
384+
- uses: actions/setup-python@v5
380385
with:
381386
python-version: 3.10.10
382-
- uses: actions/checkout@v3
387+
- uses: actions/checkout@v4
383388
with:
384389
submodules: 'true'
385390
- run: ./.github/scripts/install_dependencies.sh
@@ -411,10 +416,10 @@ jobs:
411416
name: 'B: ${{ matrix.name }}'
412417
steps:
413418

414-
- uses: actions/setup-python@v4
419+
- uses: actions/setup-python@v5
415420
with:
416421
python-version: 3.10.10
417-
- uses: actions/checkout@v3
422+
- uses: actions/checkout@v4
418423
with:
419424
submodules: 'true'
420425
- run: ./.github/scripts/install_dependencies.sh
@@ -447,10 +452,10 @@ jobs:
447452
runs-on: ubuntu-22.04
448453
steps:
449454

450-
- uses: actions/setup-python@v4
455+
- uses: actions/setup-python@v5
451456
with:
452457
python-version: 3.10.10
453-
- uses: actions/checkout@v3
458+
- uses: actions/checkout@v4
454459
with:
455460
submodules: 'true'
456461
- run: ./.github/scripts/install_dependencies.sh

0 commit comments

Comments
 (0)