Skip to content

Place 3d #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 168 commits into from
Jun 29, 2023
Merged

Place 3d #2264

merged 168 commits into from
Jun 29, 2023

Conversation

amin1377
Copy link
Contributor

@amin1377 amin1377 commented Mar 29, 2023 •
edited by saaramahmoudi
Loading

In this PR, the placement engine and all of the related data structure are update to accommodate for 3D FPGAs.

Motivation and Context

Add the support for 3D FPGAs to VPR

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@amin1377
pass number of dice (layers) to t_annealing_state
8d26d0c
@amin1377
Merge branch 'grid_3d' of https://github.com/verilog-to-routing/vtr-v…
c1bbb6c 
…erilog-to-routing into place_3d
@amin1377
Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…
f432606 
…rilog-to-routing into place_3d
@amin1377
add layer_num to t_pl_loc - minor debugging
c38a158
@amin1377
remove max_width.. from device_grid - set layer num to zero
87d283e
@amin1377
adapt find_to_loc_uniform to 3d grid - minimal change to compressed_grid
92698c7
@amin1377
add grid_x_to_cx_approx to compressed_grid
9552620
@amin1377
adapt find_to_loc_centroid to 3d
f191bce
@amin1377
debug: compressed_grid.h
33ab4da
@amin1377
adapt find_to_loc_median to 3d
db8bb85
@amin1377
remove cx_from and cy_from from find_to_loc_median
91949d9
@amin1377
remove min/max_cx/cy from find_to_loc_centroid
79f36d0
@amin1377
remove t_compressed_loc and use t_type_loc instead
6a55de0
@amin1377
add layer_num to t_type_loc
03e5c7a
@amin1377
use search_range in find_compatible_compressed_loc_in_range - remove …
7b4311d 
…redundant if block in the same function - use from_loc and to_loc in the function arguments
@amin1377
adapt find_cetroid_neighbor to new changes
f6a1561
@amin1377
refactor and debug initial_placement:init_blk_types_empty_locations
7b21d58
@amin1377
refactor try_exhaustive_placement - add compatible_sub_tile_num to co…
8138000 
…mpressed_grid
@amin1377
refactor try_random_placement - add get_layer_nums to compressed_grid
f3cfaa8
@amin1377
refactor intersect_range_limit_with_floorplan_constraints with search…
3a5e5ad 
…_range - pass to_layer_num to find_compatible_compressed_loc_in_range
@amin1377
minor debugging - add assertion to t_search_range constructor
0c40035
@amin1377
abstract away grid in compressed_grid
f484268
@amin1377
abstract away compatible_sub_tiles_for_tile in compressed_grid
ad2e608
@amin1377
make the data members of compressed_grid 3d
3786152
@amin1377
minor debugging
cc128d4
@amin1377
resize x_locs and y_locs in create_compressed_block_grid - debug
3606ee3
@amin1377
debug: add a condition in find_compatible_compressed_loc_in_range to …
eb81454 
…check whether lower_iter is larger than max_y
@amin1377
Put back the if block that enlarge the search_range in find_compatibl…
833bf5e 
…e_compressed_loc_in_range
@amin1377
remove the newly added if condition in find_compatible_compressed_loc…
7fd6bd3 
…_in_range
@amin1377
merge with grid_3d
a871f34
vaughnbetz
vaughnbetz reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes ... then merge!

saaramahmoudi and others added 12 commits May 25, 2023 16:39
@saaramahmoudi
Merge branch 'master' into place_3d
891c474
@saaramahmoudi
Merge branch 'master' into place_3d
29d3008
@amin1377
add comments on contraints_writer and RegionRectCoord
46fc5e1
@amin1377
add comments on compressed grid layer - add assertion to ensure havin…
5953bec 
…g a single layer when building clock
@amin1377
Commenting out symbiflow tests from vtr nightly test 1
1148e4c
@amin1377
make format
72041db
@amin1377
fix the arch dir in the config files of noc 3d tests
24c328e
@amin1377
add layer_num dim to t_src_opin_delays & t_chan_ipins_delays
cdc5e14
@amin1377
prevent dijkstra flood to go to a different layer - add layer_num to …
70d62ce 
…pick_sample_tile
@amin1377
adapt router_lookahead_extended_map to the additional dimention of sr…
0e1bfb4 
…c_opin_delays & chan_ipins_delays
@amin1377
make format
6875e5f
@amin1377
use from_layer to access src_opin_delays in get_expected_delay_and_co…
e00c477 
…ng - router lookahead map
@saaramahmoudi saaramahmoudi mentioned this pull request May 31, 2023
Merged
7 tasks
vaughnbetz
vaughnbetz requested changes Jun 13, 2023
View reviewed changes
@vaughnbetz
Copy link
Contributor

Looks good; feel free to merge once conflicts are resolved. Good to do final QoR check to be very careful, on the latest code.

amin1377 and others added 8 commits June 21, 2023 17:14
@saaramahmoudi
Copy link
Contributor

@vaughnbetz @amin1377 This PR is ready to merge. All CIs are green.

@vaughnbetz vaughnbetz merged commit 83dc3c4 into master Jun 29, 2023
@vaughnbetz vaughnbetz deleted the place_3d branch June 29, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz requested changes

Assignees
No one assigned
Labels
libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amin1377 @vaughnbetz @saaramahmoudi