-
Notifications
You must be signed in to change notification settings - Fork 415
Update Documentation with recent changes for Yosys Plugins #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Seyed Alireza Damghani <[email protected]>
…ugins Signed-off-by: Seyed Alireza Damghani <[email protected]>
…r the VTR front-ends Signed-off-by: Seyed Alireza Damghani <[email protected]>
…DM plugins Signed-off-by: Seyed Alireza Damghani <[email protected]>
Signed-off-by: Seyed Alireza Damghani <[email protected]>
Signed-off-by: Seyed Alireza Damghani <[email protected]>
7575cef
to
82a50d8
Compare
@vaughnbetz - This PR is ready for your review. It would be great to know your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; some typos and clarifications (e.g. what is UHDM?) requested.
There's a comment that vpr can only handle positive-edge triggered registers; asking @kmurray if that's true since I thought Tatum handled negative-edge triggered registers.
./run_vtr_flow <path/to/SystemVerilog/File> <path/to/arch/file> -elaborator yosys -fflegalize | ||
|
||
# Using the Surelog plugin if installed, otherwise failure on the unsupported file type | ||
./run_vtr_flow <path/to/UHDM/File> <path/to/arch/file> -elaborator yosys -fflegalize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should explain what a UHDM file is and how it was created (run an earlier Surelog command?). Can be brief and include a link to the UHDM documentation, but should give some idea I think.
Signed-off-by: Seyed Alireza Damghani <[email protected]>
@vaughnbetz - I have applied some changes to address your reviews. Kindly, let me know if you want additional modifications. |
Thanks Seyed. |
I think it looks good and am going to merge it. I have one last thing to consider for a follow-up PR though. |
Thanks @vaughnbetz - that absolutely makes sense. I will investigate more about the file extensions and will add more info to the documentation. Meanwhile, I noticed that Surelog or even Yosys plugins do not check the file extension; they only read whatever is inside the file using the user-specified parser. For instance, you can have a file with
Overall, the VTR flow does not check the file extension for deciding about the parser, the same as Surelog and Yosys. That means, the file extension is unimportant; however, the parser value is. If you would like, I can add to the documentation that files that include UHDM descriptions can have both |
Thanks Seyed. You could just say "typically .v or .sv files". Basically right now the documentation makes it sounds like UHDM is a file type (some .uhdm extension or some such) and it really isn't -- it's a parser flow. Clarifying that would be good. |
Description
This PR includes:
Related Issue
#2068
#2086
#2110
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: