-
Notifications
You must be signed in to change notification settings - Fork 415
Add unconnected port options for Verilog netlist #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unconnected port options for Verilog netlist #1789
Conversation
59b4d1f
to
4ef3a7c
Compare
The code looks good. My only suggestion is that this comment on how the special unconnected nets are named in this PR seems like it should be put in the code somewhere too (perhaps in create_unconn_net, if there isn't a comment on that function already):
I forced a kokoro restart since they didn't run. It also looks like the code needs to be run through |
yosys + odin failure is expected. @tjurtsch : can you do a make format to pass that test and add the comment I mention above? Then we can merge this. |
@sfkhalid : can I get you to take over closing this out? I think you just need to do a make format on this and push it (I'll watch CI to check it all works). |
4ef3a7c
to
0e5a4e3
Compare
…is netlist Co-authored-by: Alessandro Comodi <[email protected]> Co-authored-by: Pawel Czarnecki <[email protected]> Signed-off-by: Maciej Kurc <[email protected]>
Co-authored-by: Alessandro Comodi <[email protected]> Co-authored-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
0e5a4e3
to
88690ff
Compare
Signed-off-by: Pawel Czarnecki <[email protected]>
88690ff
to
c425978
Compare
I've added explanation of the names of generated nets in help messages as well as documentation entry about the new command line options. @sfkhalid could you please take a look at the updates and let me know if everything is OK here? |
Kokoro looks like it got stuck; doing a force rerun. Other than that it looks good to merge to me. |
Description
This PR adds two options:
These options can be used to enforce how unconnected ports are treated in Verilog output. They can be tied to vcc, gnd, 1'bX (unconnected) or to a special net named __vpr__unconnXX (XX number is incremented to generate unique net for each port).
Related Issue
#1721
Motivation and Context
Previously unconnected input ports were always tied to 1'b0 and output ports were tied to a common net DummyOut which is incorrect.
How Has This Been Tested?
These options were tested with symbiflow-arch-defs
To reproduce the test, build the vpr end set env variable:
Then, in a different directory, clone and build symbiflow-arch-defs:
Run an example with unconnected ports
Check out resulting and2_post_synthesis.v file.
You can change post_synth_netlist_unconn options in quicklogic/qlf_k4n8/CMakeLists.txt file.
Types of changes
Checklist: