Skip to content

Fixing up minor errors within the documentation #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

Srivat97
Copy link
Contributor

Fixed documentation errors found within the architecture modelling tutorials section and the architectural reference section.

Description

  • Within the Tutorials section
    • Under the Fracturable Multiplier Bus-Based Complete Example
      • When describing the primitives within the DSP slice, number of flip-flops to be instantiated was 64, but should be 72
  • Within the Architecture Reference section
    • Under the tag
      • The optional attributes for spaces between tiles should be incrx not incry
    • Under the tag
      • The descritpion for incry should be "An expression specifying the vertical increment between block instantiations
        within the region." instead of "An expression specifying the horizontal increment between block instantiations
        within the region."
    • Under the <equivalent_sites> tag
      • The note for should have "need" replaced with "needed"

Related Issue

Motivation and Context

This change fixed errors within the VTR documentation. These changes were necessary as they help create a more clearer documentation for other users

How Has This Been Tested?

The documentation was built after the changes and visual confirmation was done to make sure the changes were applied and that there were no build issues with the documentation.

Additionally, the basic and strong tests were done to ensure proper functionality.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Srivat97 added 2 commits June 20, 2021 11:59
Bus-Based tutorials

The error was located within the paragraph that described the sets of
flip-flops used to register the input and output ports. Originally, the
documentation listed that there were 64 flip-flops for the output port,
but it should be 72 flip-flops.
section

The first error was found under the "row" tag description. Originally,
one of the optional attributes was "icry", this was changed to "incrx".
Since horizontal increments are in the x-axis.

The second error was found under the "region" tag description.
Originally, the description for the optional attribute "incry" was "An
expression specifying the horizontal increment between block
instantiations within the region.", horizontal was changed to vertical.

The third error was found under the "equivalent_sites" tag description.
Originally the note under the "direct" tag said "This tag is need only
if the pin_mapping of the site is defined as custom", need was changed
to needed.
@Srivat97 Srivat97 requested a review from vaughnbetz June 20, 2021 19:32
@vaughnbetz
Copy link
Contributor

Looks good; thanks Srivatsan.

@vaughnbetz vaughnbetz merged commit 94e5aae into master Jun 21, 2021
@vaughnbetz vaughnbetz deleted the documentation_cleanup branch June 21, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants