-
Notifications
You must be signed in to change notification settings - Fork 212
promote new challenge pages to topgear #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submission 518508 by mishacucicea to the challenge http://www.topcoder.com/challenge-details/30059356/?type=develop
Submission #518902 by daft300punk to the challenge http://www.topcoder.com/challenge-details/30059412/?type=develop
Submit-related actions / reducers / services have been moved and merged into their challenge-related counterparts (this functionality really belongs to a challenge, no need for a separate modules with just a few functions). Also fixes lint errors. WIP: #488
Those updated, probably, can improve performance / sequrity without causing much problems (i.e. breaking anything / demanding to rework our code). There is bunch more staff to be updated, but it will need a bit more care.
Submission #519122 by maxceem to the challenge http://www.topcoder.com/challenge-details/30059492/?type=develop
Now the status of these phases (Opened / Closed) is taken from "phaseStatus" field of the relevant phase data objects, and not from comparison of phase end time with the current time (because Topcoder API allows to manually re-open some phases past the end, thus the new behavior is consistent with API). Fixes #492
Resolves various issues from #499
…TopGear also these pages are modified to ensure that all links work properly in different locations, where they can be mounted
- For design challenges - temporarly switched to the older submission page; - For dev submit confirmation - buttons are updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.